Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure

Daniel Walker
2007-08-01T18:31:53Z

On Wed, 2007-08-01 at 22:12 +0400, Oleg Nesterov wrote:

> And I personally think it is not very useful, even if it was correct.
> You can create your own workqueue and change the priority of cwq->thread.

This change is more dynamic than than just setting a single priority ..
There was some other work going on around this, so it's not totally
clear what the benefits are ..

> > > @@ -168,7 +171,7 @@ int fastcall queue_work(struct workqueue
> > > int ret = 0, cpu = raw_smp_processor_id();
> > >
> > > if (!test_and_set_bit(WORK_STRUCT_PENDING, work_data_bits(work))) {
> > > - BUG_ON(!list_empty(&work->entry));
> > > + BUG_ON(!plist_node_empty(&work->entry));
> > > __queue_work(wq_per_cpu(wq, cpu), work);
> > > ret = 1;
>
> Side note, looks like you use some strange kernel. This raw_smp_processor_id()
> above is wrong.

As the topic suggests , it's a Real Time kernel .. I can give you a link
where to download it if you want.

Daniel