Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure

Gregory Haskins
2007-08-06T15:52:16Z

On Mon, 2007-08-06 at 19:36 +0400, Oleg Nesterov wrote:

> > Well, the "trylock+requeue" avoids the obvious recursive deadlock, but
> > it introduces a more subtle error: the reschedule effectively bypasses
> > the flush.
>
> this is OK, flush_workqueue() should only care about work_struct's that are
> already queued.

Agreed.

>
> > E.g. whatever work was being flushed was allowed to escape
> > out from behind the barrier. If you don't care about the flush working,
> > why do it at all?
>
> The caller of flush_workueue() doesn't necessary know we have such a work
> on list. It just wants to flush its own works.

I was assuming that the work being flushed was submitted by the same
context, but I think I see what you are saying now. Essentially if that
queued work was unrelated to the thread that was doing the flush, it
doesn't care if it gets rescheduled.

Do you agree that if the context was the same there is a bug? Or did I
miss something else?

-Greg