* [PATCH] Eliminate warnings in ide-tape.c
@ 2007-07-30 4:42 Stephen Rothwell
2007-08-01 20:49 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2007-07-30 4:42 UTC (permalink / raw)
To: Gadi Oxman; +Cc: LKML
drivers/ide/ide-tape.c: In function '__idetape_kmalloc_stage':
drivers/ide/ide-tape.c:2588: warning: large integer implicitly truncated to unsigned type
drivers/ide/ide-tape.c:2616: warning: large integer implicitly truncated to unsigned type
b_size in struct idetape_bh is an unsigned short. We sometimes assigne
PAGE_SIZE to it and PAGE_SIZE can be 64K or larger, so make it a u32.
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/ide/ide-tape.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index e82bfa5..1fa5794 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -640,7 +640,7 @@ typedef enum {
} idetape_chrdev_direction_t;
struct idetape_bh {
- unsigned short b_size;
+ u32 b_size;
atomic_t b_count;
struct idetape_bh *b_reqnext;
char *b_data;
--
1.5.2.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Eliminate warnings in ide-tape.c
2007-07-30 4:42 [PATCH] Eliminate warnings in ide-tape.c Stephen Rothwell
@ 2007-08-01 20:49 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-08-01 20:49 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Gadi Oxman, LKML
On Monday 30 July 2007, Stephen Rothwell wrote:
> drivers/ide/ide-tape.c: In function '__idetape_kmalloc_stage':
> drivers/ide/ide-tape.c:2588: warning: large integer implicitly truncated to unsigned type
> drivers/ide/ide-tape.c:2616: warning: large integer implicitly truncated to unsigned type
>
> b_size in struct idetape_bh is an unsigned short. We sometimes assigne
> PAGE_SIZE to it and PAGE_SIZE can be 64K or larger, so make it a u32.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-01 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-30 4:42 [PATCH] Eliminate warnings in ide-tape.c Stephen Rothwell
2007-08-01 20:49 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox