From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Nigel Cunningham <nigel@nigel.suspend2.net>,
Oleg Nesterov <oleg@tv-sign.ru>, Pavel Machek <pavel@ucw.cz>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: [PATCH -mm 1/3] Freezer: Be more verbose
Date: Wed, 1 Aug 2007 23:30:43 +0200 [thread overview]
Message-ID: <200708012330.44719.rjw@sisk.pl> (raw)
In-Reply-To: <200708012328.23939.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
Increase the freezer's verbosity a bit, so that it's easier to read problem
reports related to it.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Nigel Cunningham <nigel@nigel.suspend2.net>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
kernel/power/process.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
Index: linux-2.6.23-rc1/kernel/power/process.c
===================================================================
--- linux-2.6.23-rc1.orig/kernel/power/process.c 2007-07-24 00:13:46.000000000 +0200
+++ linux-2.6.23-rc1/kernel/power/process.c 2007-07-24 00:13:58.000000000 +0200
@@ -227,18 +227,21 @@ int freeze_processes(void)
{
int error;
- printk("Stopping tasks ... ");
+ printk("Freezing user space processes ... ");
error = try_to_freeze_tasks(FREEZER_USER_SPACE);
if (error)
- return error;
+ goto Exit;
+ printk("done.\n");
+ printk("Freezing remaining freezable tasks ... ");
error = try_to_freeze_tasks(FREEZER_KERNEL_THREADS);
if (error)
- return error;
-
- printk("done.\n");
+ goto Exit;
+ printk("done.");
+ Exit:
BUG_ON(in_atomic());
- return 0;
+ printk("\n");
+ return error;
}
static void thaw_tasks(int thaw_user_space)
next prev parent reply other threads:[~2007-08-01 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 21:28 [PATCH -mm 0/3] Freezer: Use wait queue instead of busy looping Rafael J. Wysocki
2007-08-01 21:30 ` Rafael J. Wysocki [this message]
2007-08-01 21:32 ` [PATCH -mm 2/3] " Rafael J. Wysocki
2007-08-01 23:48 ` Andrew Morton
2007-08-02 11:15 ` Rafael J. Wysocki
2007-08-02 17:38 ` [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping (updated) Rafael J. Wysocki
2007-08-02 18:40 ` Oleg Nesterov
2007-08-02 21:13 ` Rafael J. Wysocki
2007-08-02 21:23 ` Oleg Nesterov
2007-08-02 21:49 ` Rafael J. Wysocki
2007-08-02 22:05 ` Oleg Nesterov
2007-08-01 21:36 ` [PATCH -mm 3/3] Freezer: Measure freezing time Rafael J. Wysocki
2007-08-01 23:53 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708012330.44719.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=nigel@nigel.suspend2.net \
--cc=oleg@tv-sign.ru \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox