From: Andrew Morton <akpm@linux-foundation.org>
To: Yinghai.Lu@Sun.COM
Cc: Daniel Ritz <daniel.ritz-ml@swissonline.ch>,
Linus Torvalds <torvalds@linux-foundation.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-kernel@vger.kernel.org
Subject: Re: REGRESSION: serial_cs broken by 8250 changes
Date: Thu, 2 Aug 2007 16:35:47 -0700 [thread overview]
Message-ID: <20070802163547.39f41af1.akpm@linux-foundation.org> (raw)
In-Reply-To: <46B267BA.4030006@sun.com>
On Thu, 02 Aug 2007 16:24:42 -0700
Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> Daniel Ritz wrote:
> > commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly
> > with an oops, completely killing PCMCIA.
> >
> > register_console() now calls console->early_setup(). which in case of
> > 8250.c (the only user anyway) is serial8250_console_early_setup()
> > which is __init, calling 8250_early.c:serial8250_find_port_for_earlycon()
> > which is __init as well. boom.
> >
> > the changelog mentions SERIAL_PORT_DFNS removal which happens to be
> > commit 7e92b4fc345f5b6f57585fbe5ffdb0f24d7c9b26. but this got reverted
> > by commit 57d4810ea0d9ca58a7bcc1336607f0cede0a2abf. so i'd suggest to
> > just revert the 8250 changes as well.
> >
> > rgds
> > -daniel
>
> Is there any flag or sign that init code has been released?
Nope.
> We could use that to prevent init code to be called after code is freed.
If we can omit a function call without breaking anything then we shouldn't
have been calling that function at all ;)
It sounds like making serial8250_console_early_setup() and
serial8250_find_port_for_earlycon() non-__init will fix this.
next prev parent reply other threads:[~2007-08-02 23:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 23:06 REGRESSION: serial_cs broken by 8250 changes Daniel Ritz
2007-08-02 23:15 ` Andrew Morton
2007-08-02 23:24 ` Yinghai Lu
2007-08-02 23:35 ` Andrew Morton [this message]
2007-08-03 0:18 ` Yinghai Lu
2007-08-03 14:07 ` Daniel Ritz
2007-08-03 16:54 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070802163547.39f41af1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Yinghai.Lu@Sun.COM \
--cc=bjorn.helgaas@hp.com \
--cc=daniel.ritz-ml@swissonline.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox