Re: Section mismatch warnings

[Sam Ravnborg <sam@ravnborg.org>]

On Thu, Aug 02, 2007 at 07:12:36PM +0200, Gabriel C wrote:
> Sam Ravnborg wrote:
> > On Thu, Aug 02, 2007 at 04:27:34PM +0200, Gabriel C wrote:
> >>>>> WARNING: vmlinux.o(.init.text+0x29d40): Section mismatch: reference to .exit.text:wbsd_release_resources (between 'wbsd_init' and 'wbsd_probe')
> >>>>> WARNING: vmlinux.o(.init.text+0x29d49): Section mismatch: reference to .exit.text:wbsd_free_mmc (between 'wbsd_init' and 'wbsd_probe')
> >>>>> WARNING: vmlinux.o(.init.text+0x29f28): Section mismatch: reference to .exit.text:wbsd_free_mmc (between 'wbsd_init' and 'wbsd_probe')
> >>>> When a function is marked __exit and used from an init function then the safe choice
> >>>> is to just remove the __exit marking. Usually this is small functions used
> >>>> only in error situations.
> >>>> Should be trivial too.
> >>> I'll look at those too
> >>>
> >>>> Sorry - no patch this time. Could you try to look at it yorself then I will review.
> >>> Ok I'll try.
> >>>
> >> The warnings gone with this patch but I'm not really sure it is correct.
> > Looks correct to me.
> > You drop the __devexit marking for functions used outside __exit.
> > Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> Shall I send this one to akpm with your ACK or you take care of it ?
Please forward it to akpm.
I usually do not carry non-kbuild patches in my tree to keep 'noise' level down.

	Sam