public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: Greg KH <gregkh@suse.de>,
	linux-kernel@vger.kernel.org,
	Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH] debugfs helper for decimal challenged
Date: Thu, 2 Aug 2007 14:09:25 -0700	[thread overview]
Message-ID: <20070802210925.GA6199@kroah.com> (raw)
In-Reply-To: <200708012313.51933.rgetz@blackfin.uclinux.org>

On Wed, Aug 01, 2007 at 11:13:51PM -0400, Robin Getz wrote:
> From: Robin Getz <rgetz@blackfin.uclinux.org>
> 
> Allows debugfs helper functions to have a hex output, rather than just decimal
>  
> Signed-off-by:  Robin Getz <rgetz@blackfin.uclinux.org>
> ---
>  fs/debugfs/file.c |   36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)

You forgot to add the prototypes to the debugfs.h file so that people
can actually use these functions :)

Care to redo this?

> --- fs/debugfs/file.c	(revision 3529)
> +++ fs/debugfs/file.c	(working copy)

Oh, and add another level to the patch so it can be applied with "-p1"
by patch.

thanks,

greg k-h

  reply	other threads:[~2007-08-02 21:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 21:52 debugfs helper for decimal challenged Robin Getz
2007-08-01 22:25 ` Greg KH
2007-08-02  3:13   ` [PATCH] " Robin Getz
2007-08-02 21:09     ` Greg KH [this message]
2007-08-02 22:20       ` Robin Getz
2007-08-02 22:23       ` Robin Getz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070802210925.GA6199@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgetz@blackfin.uclinux.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox