debugfs helper for decimal challenged

debugfs helper for decimal challenged

[Robin Getz]

Greg:

For those of us who forget that when bits 21 and bit 31 in a hardware 
register exposed with debugfs, I should see 2149580800 when I cat it (vs
0x80200000), any objections to providing a hex output interface to the 
debugfs?

Since the input side already takes decimal & hex, I don't think this is a big
change:

DEFINE_SIMPLE_ATTRIBUTE(fops_x16, debugfs_u16_get, debugfs_u16_set, "0x%04llx\n");

struct dentry *debugfs_create_x16(const char *name, mode_t mode,
                                  struct dentry *parent, u16 *value)
{
        return debugfs_create_file(name, mode, parent, value, &fops_x16);
}

DEFINE_SIMPLE_ATTRIBUTE(fops_x32, debugfs_u32_get, debugfs_u32_set, "0x%08llx\n");

struct dentry *debugfs_create_x32(const char *name, mode_t mode,
                                  struct dentry *parent, u32 *value)
{
        return debugfs_create_file(name, mode, parent, value, &fops_x32);
}

If this is OK - I will send a real patch.

-Robin

Re: debugfs helper for decimal challenged

[Greg KH]

On Wed, Aug 01, 2007 at 05:52:58PM -0400, Robin Getz wrote:
> Greg:
> 
> For those of us who forget that when bits 21 and bit 31 in a hardware 
> register exposed with debugfs, I should see 2149580800 when I cat it (vs
> 0x80200000), any objections to providing a hex output interface to the 
> debugfs?
> 
> Since the input side already takes decimal & hex, I don't think this is a big
> change:
> 
> DEFINE_SIMPLE_ATTRIBUTE(fops_x16, debugfs_u16_get, debugfs_u16_set, "0x%04llx\n");
> 
> struct dentry *debugfs_create_x16(const char *name, mode_t mode,
>                                   struct dentry *parent, u16 *value)
> {
>         return debugfs_create_file(name, mode, parent, value, &fops_x16);
> }
> 
> DEFINE_SIMPLE_ATTRIBUTE(fops_x32, debugfs_u32_get, debugfs_u32_set, "0x%08llx\n");
> 
> struct dentry *debugfs_create_x32(const char *name, mode_t mode,
>                                   struct dentry *parent, u32 *value)
> {
>         return debugfs_create_file(name, mode, parent, value, &fops_x32);
> }
> 
> If this is OK - I will send a real patch.

That sounds good to me, feel free to send a real patch.

thanks,

greg k-h

[PATCH] debugfs helper for decimal challenged

[Robin Getz]

From: Robin Getz <rgetz@blackfin.uclinux.org>

Allows debugfs helper functions to have a hex output, rather than just decimal
 
Signed-off-by:  Robin Getz <rgetz@blackfin.uclinux.org>
---
 fs/debugfs/file.c |   36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

Index: fs/debugfs/file.c
===================================================================
--- fs/debugfs/file.c	(revision 3529)
+++ fs/debugfs/file.c	(working copy)
@@ -179,6 +179,42 @@
 }
 EXPORT_SYMBOL_GPL(debugfs_create_u32);
 
+DEFINE_SIMPLE_ATTRIBUTE(fops_x8, debugfs_u8_get, debugfs_u8_set, "0x%02llx\n");
+
+DEFINE_SIMPLE_ATTRIBUTE(fops_x16, debugfs_u16_get, debugfs_u16_set, "0x%04llx\n");
+
+DEFINE_SIMPLE_ATTRIBUTE(fops_x32, debugfs_u32_get, debugfs_u32_set, "0x%08llx\n");
+
+/**
+ * debugfs_create_x8 - create a debugfs file that is used to read and write an unsigned 8-bit value
+ * debugfs_create_x16 - create a debugfs file that is used to read and write an unsigned 16-bit value
+ * debugfs_create_x32 - create a debugfs file that is used to read and write an unsigned 32-bit value
+ *
+ * These functions are exactly the same as the above functions, (but use a hex
+ * output for the decimal challenged) for details look at the above unsigned
+ * decimal functions.
+ */
+struct dentry *debugfs_create_x8(const char *name, mode_t mode,
+				 struct dentry *parent, u8 *value)
+{
+	return debugfs_create_file(name, mode, parent, value, &fops_x8);
+}
+EXPORT_SYMBOL_GPL(debugfs_create_x8);
+
+struct dentry *debugfs_create_x16(const char *name, mode_t mode,
+				 struct dentry *parent, u16 *value)
+{
+	return debugfs_create_file(name, mode, parent, value, &fops_x16);
+}
+EXPORT_SYMBOL_GPL(debugfs_create_x16);
+
+struct dentry *debugfs_create_x32(const char *name, mode_t mode,
+				 struct dentry *parent, u32 *value)
+{
+	return debugfs_create_file(name, mode, parent, value, &fops_x32);
+}
+EXPORT_SYMBOL_GPL(debugfs_create_x32);
+
 static ssize_t read_file_bool(struct file *file, char __user *user_buf,
 			      size_t count, loff_t *ppos)
 {

Re: [PATCH] debugfs helper for decimal challenged

[Greg KH]

On Wed, Aug 01, 2007 at 11:13:51PM -0400, Robin Getz wrote:
> From: Robin Getz <rgetz@blackfin.uclinux.org>
> 
> Allows debugfs helper functions to have a hex output, rather than just decimal
>  
> Signed-off-by:  Robin Getz <rgetz@blackfin.uclinux.org>
> ---
>  fs/debugfs/file.c |   36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)

You forgot to add the prototypes to the debugfs.h file so that people
can actually use these functions :)

Care to redo this?

> --- fs/debugfs/file.c	(revision 3529)
> +++ fs/debugfs/file.c	(working copy)

Oh, and add another level to the patch so it can be applied with "-p1"
by patch.

thanks,

greg k-h

Re: [PATCH] debugfs helper for decimal challenged

[Robin Getz]

On Thu 2 Aug 2007 17:09, Greg KH pondered:
> On Wed, Aug 01, 2007 at 11:13:51PM -0400, Robin Getz wrote:
> > From: Robin Getz <rgetz@blackfin.uclinux.org>
> > 
> > Allows debugfs helper functions to have a hex output, rather than just
> decimal
> >  
> > Signed-off-by:  Robin Getz <rgetz@blackfin.uclinux.org>
> > ---
> >  fs/debugfs/file.c |   36 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> 
> You forgot to add the prototypes to the debugfs.h file so that people
> can actually use these functions :)
> 
> Care to redo this?

No problem.

> > --- fs/debugfs/file.c	(revision 3529)
> > +++ fs/debugfs/file.c	(working copy)
> 
> Oh, and add another level to the patch so it can be applied with "-p1"
> by patch.

will do.

[PATCH] debugfs helper for decimal challenged

[Robin Getz]

From: Robin Getz <rgetz@blackfin.uclinux.org>
 
Allows debugfs helper functions to have a hex output, rather than just decimal
 
Signed-off-by:  Robin Getz <rgetz@blackfin.uclinux.org>
---

 fs/debugfs/file.c       |   36 ++++++++++++++++++++++++++++++++++++
 include/linux/debugfs.h |   27 +++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)

Index: linux-2.6.x/include/linux/debugfs.h
===================================================================
--- linux-2.6.x/include/linux/debugfs.h	(revision 3534)
+++ linux-2.6.x/include/linux/debugfs.h	(working copy)
@@ -44,6 +44,12 @@
 				  struct dentry *parent, u16 *value);
 struct dentry *debugfs_create_u32(const char *name, mode_t mode,
 				  struct dentry *parent, u32 *value);
+struct dentry *debugfs_create_x8(const char *name, mode_t mode,
+				 struct dentry *parent, u8 *value);
+struct dentry *debugfs_create_x16(const char *name, mode_t mode,
+				 struct dentry *parent, u16 *value);
+struct dentry *debugfs_create_x32(const char *name, mode_t mode,
+				 struct dentry *parent, u32 *value);
 struct dentry *debugfs_create_bool(const char *name, mode_t mode,
 				  struct dentry *parent, u32 *value);
 
@@ -104,6 +110,27 @@
 	return ERR_PTR(-ENODEV);
 }
 
+static inline struct dentry *debugfs_create_x8(const char *name, mode_t mode,
+					       struct dentry *parent,
+					       u8 *value)
+{
+	return ERR_PTR(-ENODEV);
+}
+
+static inline struct dentry *debugfs_create_x16(const char *name, mode_t mode,
+						struct dentry *parent,
+						u16 *value)
+{
+	return ERR_PTR(-ENODEV);
+}
+
+static inline struct dentry *debugfs_create_x32(const char *name, mode_t mode,
+						struct dentry *parent,
+						u32 *value)
+{
+	return ERR_PTR(-ENODEV);
+}
+
 static inline struct dentry *debugfs_create_bool(const char *name, mode_t mode,
 						 struct dentry *parent,
 						 u32 *value)
Index: linux-2.6.x/fs/debugfs/file.c
===================================================================
--- linux-2.6.x/fs/debugfs/file.c	(revision 3534)
+++ linux-2.6.x/fs/debugfs/file.c	(working copy)
@@ -179,6 +179,42 @@
 }
 EXPORT_SYMBOL_GPL(debugfs_create_u32);
 
+DEFINE_SIMPLE_ATTRIBUTE(fops_x8, debugfs_u8_get, debugfs_u8_set, "0x%02llx\n");
+
+DEFINE_SIMPLE_ATTRIBUTE(fops_x16, debugfs_u16_get, debugfs_u16_set, "0x%04llx\n");
+
+DEFINE_SIMPLE_ATTRIBUTE(fops_x32, debugfs_u32_get, debugfs_u32_set, "0x%08llx\n");
+
+/**
+ * debugfs_create_x8 - create a debugfs file that is used to read and write an unsigned 8-bit value
+ * debugfs_create_x16 - create a debugfs file that is used to read and write an unsigned 16-bit value
+ * debugfs_create_x32 - create a debugfs file that is used to read and write an unsigned 32-bit value
+ *
+ * These functions are exactly the same as the above functions, (but use a hex
+ * output for the decimal challenged) for details look at the above unsigned
+ * decimal functions.
+ */
+struct dentry *debugfs_create_x8(const char *name, mode_t mode,
+				 struct dentry *parent, u8 *value)
+{
+	return debugfs_create_file(name, mode, parent, value, &fops_x8);
+}
+EXPORT_SYMBOL_GPL(debugfs_create_x8);
+
+struct dentry *debugfs_create_x16(const char *name, mode_t mode,
+				 struct dentry *parent, u16 *value)
+{
+	return debugfs_create_file(name, mode, parent, value, &fops_x16);
+}
+EXPORT_SYMBOL_GPL(debugfs_create_x16);
+
+struct dentry *debugfs_create_x32(const char *name, mode_t mode,
+				 struct dentry *parent, u32 *value)
+{
+	return debugfs_create_file(name, mode, parent, value, &fops_x32);
+}
+EXPORT_SYMBOL_GPL(debugfs_create_x32);
+
 static ssize_t read_file_bool(struct file *file, char __user *user_buf,
 			      size_t count, loff_t *ppos)
 {