public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-usb-devel@lists.sourceforge.net, amitk@ubuntu.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: Only enable autosuspend by default on certain device classes
Date: Thu, 2 Aug 2007 18:15:05 -0700	[thread overview]
Message-ID: <20070803011505.GA32589@suse.de> (raw)
In-Reply-To: <20070802235613.GA9487@srcf.ucam.org>

On Fri, Aug 03, 2007 at 12:56:13AM +0100, Matthew Garrett wrote:
> We're seeing a large number of problems with devices not appreciating 
> USB autosuspend, especially printers and scanners. According to 
> http://www.microsoft.com/whdc/system/bus/USB/USBFAQ_intro.mspx only a 
> subset of drivers support it in Windows XP, meaning that most devices 
> are probably untested in this situation. This patch alters the behaviour 
> to match that of Windows. Userspace can still whitelist devices as 
> appropriate, and the set of classes supporting autosuspend probably 
> covers pretty much every driver likely to be found on any portable 
> device.
> 
> Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>

Well, if you do this, then you can pretty much delete the whole quirk
table we have, right?

And personally, I want to do better than Windows XP when it comes to
power management.  This patch is only going to suspend a very tiny
subset of devices, including a whole bunch of ones that do not even have
drivers in Linux, causing our power footprint to be bigger than needed.

Also, we have udev rules for SANE that disables their autosuspend
settings, which handles the majority of the devices we have seen with
problems.

So I really don't want to accept this patch.  But, what problems are you
seeing with our current suspend logic that you feel we need to be this
harsh?

thanks,

greg k-h

  reply	other threads:[~2007-08-03  1:12 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 23:56 [PATCH] USB: Only enable autosuspend by default on certain device classes Matthew Garrett
2007-08-03  1:15 ` Greg KH [this message]
2007-08-03  1:47   ` Matthew Garrett
2007-08-03  2:46     ` [linux-usb-devel] " Alan Stern
2007-08-03  6:01       ` David Brownell
2007-08-03 11:28         ` Matthew Garrett
2007-08-03 11:44           ` Oliver Neukum
2007-08-03 12:04             ` Matthew Garrett
2007-08-03 12:26               ` Rogan Dawes
2007-08-03 12:32                 ` Matthew Garrett
2007-08-03 14:01                   ` David Brownell
2007-08-03 14:09                     ` Matthew Garrett
2007-08-03 14:28                       ` Alan Stern
2007-08-03 14:33                         ` Matthew Garrett
2007-08-03 14:41                           ` Alan Stern
2007-08-03 15:10                             ` Matthew Garrett
2007-08-03 14:43                           ` Jiri Kosina
2007-08-03 14:53                             ` [linux-usb-devel] " Dave Jones
2007-08-03 14:58                               ` Jiri Kosina
2007-08-03 15:24                               ` David Brownell
2007-08-03 15:29                                 ` Jiri Kosina
2007-08-03 17:47                                   ` Alan Stern
2007-08-03 15:25                               ` Adam Kropelin
2007-08-03 15:31                                 ` Jiri Kosina
2007-08-03 15:48                                   ` Dave Jones
2007-08-03 16:49                                     ` David Brownell
2007-08-03 16:55                                     ` Adam Kropelin
2007-08-03 15:06                             ` Matthew Garrett
2007-08-03 14:37                       ` [linux-usb-devel] " David Brownell
2007-08-03 15:03                         ` Matthew Garrett
2007-08-03 16:08                           ` Oliver Neukum
2007-08-03 17:49                             ` Alan Stern
2007-08-03 20:03                             ` Dave Jones
2007-08-03 16:29                           ` David Brownell
2007-08-03 16:50                             ` Matthew Garrett
2007-08-03 17:49                             ` Greg KH
2007-08-03 17:44                   ` Greg KH
2007-08-03 17:48                     ` Matthew Garrett
2007-08-03 19:29                       ` Chuck Ebbert
2007-08-03 19:56                         ` Pete Zaitcev
2007-08-07  9:14                           ` Amit Kucheria
2007-08-03 20:12                     ` [linux-usb-devel] " Dave Jones
2007-08-03 21:17                       ` Alan Stern
2007-08-03 21:31                         ` Dave Jones
2007-08-03 21:33                         ` Matthew Garrett
2007-08-03 12:34                 ` Felipe Balbi
2007-08-03  6:06     ` David Brownell
2007-08-03 14:22       ` Dave Jones
2007-08-03 14:52         ` David Brownell
2007-08-03  7:57     ` Oliver Neukum
2007-08-03 14:24       ` Dave Jones
2007-08-03 14:32         ` Oliver Neukum
2007-08-03 14:36           ` [linux-usb-devel] [PATCH] USB: Only enable autosuspend by?default " Dave Jones
2007-08-03 19:34         ` [linux-usb-devel] [PATCH] USB: Only enable autosuspend by default " Pete Zaitcev
2007-08-03 19:45           ` Dave Jones
2007-08-03 20:04             ` Pete Zaitcev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070803011505.GA32589@suse.de \
    --to=gregkh@suse.de \
    --cc=amitk@ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox