public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Maurice Volaski <mvolaski@aecom.yu.edu>,
	jheffner@psc.edu, discussion@web100.org,
	linux-kernel@vger.kernel.org, drbd-user@linbit.com
Subject: Re: drbd 8.0.2/3 doesn't load under kernel 2.6.21
Date: Fri, 3 Aug 2007 16:56:17 +0200	[thread overview]
Message-ID: <20070803145617.GA8426@racke.local> (raw)
In-Reply-To: <20070802000005.GT3972@stusta.de>

On Thu, Aug 02, 2007 at 02:00:05AM +0200, Adrian Bunk wrote:
> On Wed, Aug 01, 2007 at 07:02:14PM -0400, Maurice Volaski wrote:
> > First, did you confirm this behavior? Can you please explain that? How 
> > could they possibly interact with one another?
> 
> 
> It's obvious when looking at the source code that both modules you are
> trying to use are buggy, and the sum of the bugs in both modules is the 
> drbd breakage you observe.
> 
> 
> 30% of the guilt go to the drbd developers for doing the following:
> 
> #ifdef NETLINK_ROUTE6
>         /* pre 2.6.16 */
>         err = cn_init();
>         if(err) return err;
> #endif
> 
> The author wanted to check for pre-2.6.14 when the connector code was 
> added to the kernel, not for pre-2.6.16 as the comment implies or 
> pre-2.6.13 as the code does.
> 
> Or he wanted to check whether it's a recent kernel and the connector 
> code is compiled into the kernel.

that is what we wanted to check for. iirc, we first went to test for
the kernel version, unfortunately going just for the kernel version did
not exactly work out for patched vendor kernels...
browsing over the available (to us at that time) kernel trees suggested
that misusing the define of NETLINK_ROUTE6 might just work...

> 70% of the guilt go to the web100 developers for shipping the following 
> to their users:
> 
> --- linux-2.6-web100/include/linux/netlink.h	19 Jul 2007 17:49:17 -0000	1.1.1.16
> +++ linux-2.6-web100/include/linux/netlink.h	19 Jul 2007 18:11:01 -0000	1.17
> @@ -14,6 +14,7 @@
>  #define NETLINK_SELINUX		7	/* SELinux event notifications */
>  #define NETLINK_ISCSI		8	/* Open-iSCSI */
>  #define NETLINK_AUDIT		9	/* auditing */
> +#define NETLINK_ROUTE6		11	/* af_inet6 route comm channel */
>  #define NETLINK_FIB_LOOKUP	10	
>  #define NETLINK_CONNECTOR	11
>  #define NETLINK_NETFILTER	12	/* netfilter subsystem */
>  
> That's not only buggy but also not used by web100.
> 
> 
> cu
> Adrian

thank you very much for looking at this,

-- 
: Lars Ellenberg                            Tel +43-1-8178292-0  :
: LINBIT Information Technologies GmbH      Fax +43-1-8178292-82 :
: Vivenotgasse 48, A-1120 Vienna/Europe    http://www.linbit.com :
__
please use the "List-Reply" function of your email client.

  reply	other threads:[~2007-08-03 14:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 20:21 drbd 8.0.2/3 doesn't load under kernel 2.6.21 Maurice Volaski
2007-08-01 22:34 ` Adrian Bunk
2007-08-01 23:02   ` Maurice Volaski
2007-08-02  0:00     ` Adrian Bunk
2007-08-03 14:56       ` Lars Ellenberg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-07-25 18:14 Maurice Volaski
2007-06-13  3:38 Maurice Volaski
     [not found] <20070612191821.BDB302E0787B@mail.linbit.com>
2007-06-12 20:45 ` Maurice Volaski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070803145617.GA8426@racke.local \
    --to=lars.ellenberg@linbit.com \
    --cc=bunk@stusta.de \
    --cc=discussion@web100.org \
    --cc=drbd-user@linbit.com \
    --cc=jheffner@psc.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mvolaski@aecom.yu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox