Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

Andrew Morton
2007-08-07T22:51:01Z

On Sun, 5 Aug 2007 10:53:07 +0300
Muli Ben-Yehuda <muli@il.ibm.com> wrote:

> This patch finishes the i386 and x86-64 ->sysdata conversion and
> hopefully also fixes Riku's and Andy's observed bugs. It is based on
> Yinghai Lu's and Andy Whitcroft's patches (thanks!) with some changes:
>
> - introduce pci_scan_bus_with_sysdata() and use it instead of
> pci_scan_bus() where appropriate. pci_scan_bus_with_sysdata() will
> allocate the sysdata structure and then call pci_scan_bus().
> - always allocate pci_sysdata dynamically. The whole point of this
> sysdata work is to make it easy to do root-bus specific things
> (e.g., support PCI domains and IOMMU's). I dislike using a default
> struct pci_sysdata in some places and a dynamically allocated
> pci_sysdata elsewhere - the potential for someone indavertantly
> changing the default structure is too high.
> - this patch only makes the minimal changes necessary, i.e., the NUMA node is
> always initialized to -1. Patches to do the right thing with regards
> to the NUMA node can build on top of this (either add a 'node'
> parameter to pci_scan_bus_with_sysdata() or just update the node
> when it becomes known).
>
> The patch was compile tested with various configurations (e.g., NUMAQ,
> VISWS) and run-time tested on i386 and x86-64. Unfortunately none of
> my machines exhibited the bugs so caveat emptor.
>
> Andy, could you please see if this fixes the NUMA issues you've seen?
> Riku, does this fix "pci=noacpi" on your laptop?

I am sooooooo tired of this thing. Andi, someone, can we for heaven's
sake please just get it all sorted out?

I dropped two of Yinghai's patches which conflicted with this, and then
two more which looked like they depended on the dropped ones.