Re: Oops in 2.6.23-rc1-git9, arch/x86_64/pci/k8-bus.c::fill_mp_bus_to_cpumask()

Muli Ben-Yehuda
2007-08-04T06:17:47Z

On Fri, Aug 03, 2007 at 03:50:35PM -0700, Andrew Morton wrote:
> On Fri, 03 Aug 2007 18:10:03 -0400
> Chuck Ebbert <cebbert@redhat.com> wrote:
>
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250859
> >
> > at line 74:
> >
> > muli@62829:
> > muli@62829: sd = bus->sysdata;
> > muli@62829: sd->node = node; <=====
> >
> > bus->sysdata is NULL.
> >
> > Last changed by this hunk of
> > "x86-64: introduce struct pci_sysdata to facilitate sharing of ->sysdata":
> >
> > @@ -67,7 +69,9 @@ fill_mp_bus_to_cpumask(void)
> > continue;
> > if (!node_online(node))
> > node = 0;
> > - bus->sysdata = (void *)node;
> > +
> > + sd = bus->sysdata;
> > + sd->node = node;
> > }
> > }
> > }
> >
>
> Andy keeps trotting out a patch which will probably fix this, but
> for some reason it doesn't seem to make progress.

Hmm, looks like we're missing one of the paths where sd gets
allocated.

Andy can you please point me to the latest version of your patch? I
recall thinking that it papers over the bug rather than fixing it but
would like to take a second look.

Thanks,
Muli