From: Kyle McMartin <kyle@mcmartin.ca>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Valerie Henson <val@nmt.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
tulip-users@lists.sourceforge.net, david@lang.hm,
Grant Grundler <grundler@parisc-linux.org>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH][RESEND] Semi-pointless NULL test in uli526x driver
Date: Sat, 4 Aug 2007 17:14:55 -0400 [thread overview]
Message-ID: <20070804211455.GC3530@fattire.cabal.ca> (raw)
In-Reply-To: <200708042032.12317.jesper.juhl@gmail.com>
On Sat, Aug 04, 2007 at 08:32:12PM +0200, Jesper Juhl wrote:
> I don't think dev_id can ever actually be NULL, so the whole block
> inside "if (!dev) {" could probably just go away. But I guess
> there's a good reason someone put that ULI526X_DBUG() in there - and
> if 'dev_id' /can/ actually be NULL then it's nice to have and in
> that case this patch actually fixes a possible crash (hence the
> version number update).
It *can* be null, in the case of another handler being registered on the
same irq number, passing NULL for the cookie.
Ack. Will apply.
Regards,
Kyle
next prev parent reply other threads:[~2007-08-04 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 18:32 [PATCH][RESEND] Semi-pointless NULL test in uli526x driver Jesper Juhl
2007-08-04 21:14 ` Kyle McMartin [this message]
2007-08-07 21:23 ` Jeff Garzik
2007-08-07 21:28 ` Jesper Juhl
2007-08-07 21:32 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070804211455.GC3530@fattire.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=akpm@linux-foundation.org \
--cc=david@lang.hm \
--cc=grundler@parisc-linux.org \
--cc=jeff@garzik.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tulip-users@lists.sourceforge.net \
--cc=val@nmt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox