From: David Brownell <david-b@pacbell.net>
To: Oliver Neukum <oliver@neukum.org>
Cc: Tino Keitel <tino.keitel@gmx.de>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.23-rc1: USB hard disk broken
Date: Sun, 5 Aug 2007 12:11:19 -0700 [thread overview]
Message-ID: <200708051211.19356.david-b@pacbell.net> (raw)
In-Reply-To: <200708051746.32439.oliver@neukum.org>
On Sunday 05 August 2007, Oliver Neukum wrote:
> >
> > 2007-08-05_10:30:27.75572 kern.err:
> > ehci_hcd 0000:00:1d.7: dev 6 ep1in scatterlist error 0/-121
That's rather strange since it means a *success* (urb->status 0) was
reported after a short read (scatterlist status -120, -EREMOTEIO).
The hardware should have stopped queue processing after the short
read, because of how qtd->hw_alt_next gets set up ... at least,
that's how I remember it, these many years after writing that code.
It might be that because of the issue noted below, it was wrongly
restarted by the software.
> > 2007-08-05_10:30:27.86576 kern.info: usb 1-6: reset high speed USB device using ehci_hcd and address 5
> > 2007-08-05_10:30:55.95293 kern.info: usb 1-6: USB disconnect, address 5
> > 2007-08-05_10:30:55.95300 kern.err:
> > ehci_hcd 0000:00:1d.7: dev 6 ep1in scatterlist error -108/-108
That one just means nobody updated that test to recognize that
the -ESHUTDOWN (-108) triggered after disconnect is a "clean"
failure like the ones triggered by unlinking.
However it also indicates that something changed in the unlink
code paths, since I see the *expected* code (-ECONNRESET) is no
longer being set by usbcore during unlinks ... it's not quite
clear to me what else that change will have broken. Including
whether that might not explain how the hardware queue got wrongly
restarted after the short read above.
- Dave
> David, does this error say anything to you?
next prev parent reply other threads:[~2007-08-05 19:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 7:23 2.6.23-rc1: USB hard disk broken Tino Keitel
2007-07-25 8:24 ` Oliver Neukum
2007-07-25 18:13 ` Tino Keitel
2007-07-26 8:06 ` Oliver Neukum
2007-08-05 11:09 ` Tino Keitel
2007-08-05 11:41 ` Tino Keitel
2007-08-05 15:46 ` Oliver Neukum
2007-08-05 19:11 ` David Brownell [this message]
2007-08-09 16:58 ` Dan Zwell
2007-08-09 20:00 ` Alan Stern
2007-08-09 20:25 ` Tino Keitel
2007-08-09 22:20 ` Dan Zwell
2007-08-10 14:18 ` Alan Stern
2007-08-10 20:30 ` Dan Zwell
2007-08-10 20:43 ` Alan Stern
2007-09-12 21:57 ` 2.6.23-rc1: USB hard disk broken (REGRESSION) Mark Lord
2007-09-12 22:40 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708051211.19356.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=tino.keitel@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox