public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Len Brown <lenb@kernel.org>
Cc: trenn@suse.de, Andi Kleen <andi@firstfloor.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Knut Petersen <Knut_Petersen@t-online.de>,
	linux-kernel@vger.kernel.org, mjg59@srcf.ucam.org
Subject: Re: 2.6.22 regression: thermal trip points
Date: Mon, 6 Aug 2007 11:55:04 +0200	[thread overview]
Message-ID: <20070806095504.GA1934@elf.ucw.cz> (raw)
In-Reply-To: <200708031459.07108.lenb@kernel.org>

Hi!

> > If we have something like this, we could still discuss a config option,
> > that also allows to increase trip points, marking it with "If you set
> > this you can destroy your machine, you have been warned...". While this
> > would not be an option for distributions to compile in, some people may
> > come around the biggest hammer -> overriding DSDT.
> > 
> > I cannot promise, but I try to get this for 2.6.24.
> 
> I think if you are enamored with overriding trip points at SuSE,
> that you should simply restore the original scheme as the "value add"
> for SuSE kernels.  Seriously, I'm totally fine with that.
> 
> You should be aware, however, that (one of) the fundamental flaws
> with that scheme, shared with what you describe above, is that the OS
> can not actually change the trip points in the thermal sensor.
> The sensor is going to trip at the temperature that _it_ thinks

Yep, you work around this one by enabling polling.

> This faking out the user, plus the fact that the BIOS does change
> trip-points at run-time, made the original scheme fundamentally
> unsound.  Further, I've not yet found a single system where use

Yes, this one is uglier. But maybe "enable polling automatically +
ignore any updates from bios" (+ maybe "only enable lowering") is
better solution than "just remove the knob"? After all, "the knob" is
still useful for debugging at least.

> of this scheme wasn't papering over some other problem.  For the
> upstream kernel, I think it is more appropriate to expose and fix
> the fundamental problems.  For distro kernels, I'm less concerned
> if you hide bugs instead of fixing them.

This is okay as long as you are willing to work around the fundamental
problems in kernel. You are unable to _fix_ them. They are broken
BIOSes.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2007-08-06 11:07 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02  8:40 2.6.22 regression: thermal trip points Knut Petersen
2007-08-02  8:52 ` Andrew Morton
2007-08-02 10:48   ` Andi Kleen
2007-08-02 11:00     ` Alan Cox
2007-08-02 12:05       ` Andi Kleen
2007-08-02 13:04         ` Alan Cox
2007-08-02 13:16           ` Andi Kleen
2007-08-02 15:57             ` Pavel Machek
2007-08-02 18:38               ` Andi Kleen
2007-08-02 18:40                 ` Matthew Garrett
2007-08-03 11:16                 ` Thomas Renninger
2007-08-03 18:59                   ` Len Brown
2007-08-06  9:55                     ` Pavel Machek [this message]
2007-08-07 18:58                       ` Len Brown
2007-08-07 21:49                         ` Pavel Machek
2007-08-13 12:30                           ` Pavel Machek
2007-08-02 15:55     ` Pavel Machek
2007-08-02  9:42 ` Thomas Renninger
2007-08-02  9:45   ` Adrian Schröter
2007-08-02  9:58     ` Thomas Renninger
2007-08-02 11:02       ` Alan Cox
2007-08-02 11:13         ` Matthew Garrett
2007-08-02 11:45           ` Thomas Renninger
2007-08-02 11:56             ` Matthew Garrett
2007-08-02 12:42               ` Thomas Renninger
2007-08-02 12:55                 ` Matthew Garrett
2007-08-02 11:59           ` Alan Cox
2007-08-02 11:57             ` Matthew Garrett
2007-08-02 12:06               ` Thomas Renninger
2007-08-02 12:15                 ` Matthew Garrett
2007-08-02 12:35                   ` Thomas Renninger
2007-08-02 12:47                     ` Matthew Garrett
2007-08-02 21:56     ` Len Brown
2007-08-02 11:32   ` Knut Petersen
2007-08-02 12:06     ` Andi Kleen
2007-08-02 13:06       ` Alan Cox
2007-08-02 16:07     ` Pavel Machek
2007-08-02 19:25     ` Krzysztof Halasa
2007-08-02 21:56 ` Len Brown
2007-08-03 11:43   ` Renato S. Yamane
2007-08-03 18:35     ` Len Brown
2007-08-03 12:53   ` Knut Petersen
2007-08-03 18:30     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070806095504.GA1934@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=Knut_Petersen@t-online.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andi@firstfloor.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox