public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH -mm] 2/2: PCI: disable decode of IO/memory during BAR sizing
Date: Mon, 6 Aug 2007 10:11:41 -0700	[thread overview]
Message-ID: <200708061011.42363.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <465CF804.9070907@shaw.ca>

On Tuesday, May 29, 2007 9:05 pm Robert Hancock wrote:
> Change PCI BAR sizing to disable the decode of memory or IO, as
> appropriate, while we are writing the all-ones value to the BAR to
> determine the size. If this is not done, the device may spuriously
> decode accesses to memory areas it should not. On some Intel PCI
> Express chipsets, this breaks MMCONFIG configuration space access,
> since the memory the graphics card ends up decoding during this
> period overlaps the MMCONFIG area, and thus it steals the accesses to
> the area to do any other configuration space access, including
> changing the BAR back to its previous value.
>
> However, don't do this disabling on host bridge devices, as it is
> reported that some of them do silly things like disable CPU to RAM
> access if this is done.
>
> Based on an original patch by Jesse Barnes.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>

Robert, the PCI patches for fixing up MCFG detection/usage and probing 
should go through Greg.  Can you resend so we don't miss 2.6.24 this 
time?  (I was really hoping this stuff would get into 2.6.23, but 
apparently none of the right people were Cc'd at the right time... 
damn.)

You can add my sign-off to this one too.

Thanks,
Jesse

      parent reply	other threads:[~2007-08-06 18:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-30  4:05 [PATCH -mm] 2/2: PCI: disable decode of IO/memory during BAR sizing Robert Hancock
2007-05-30 15:13 ` Jesse Barnes
2007-08-06 17:11 ` Jesse Barnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708061011.42363.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=akpm@linux-foundation.org \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox