Re: [PATCH] i386: convert mm_context_t semaphore to a mutex

Luiz Fernando N. Capitulino
2007-08-06T17:15:44Z

Em Mon, 6 Aug 2007 17:25:02 +0200
Ingo Molnar <mingo@elte.hu> escreveu:

|
| * Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br> wrote:
|
| > | hm, looks good to me but i'm wondering why this was a holdout for
| > | such a long time :-) Did you manage to test actual LDT functionality
| > | with this patch applied?
| >
| > No, I didn't. The only test I did was to run the kernel with this
| > patch applied.
| >
| > I'll manage to test it then. Do you have a test-case or has any
| > suggestion?
|
| i think try any pthread program with:
|
| export LD_ASSUME_KERNEL=2.4.0
|
| should trigger the LDT code. Try stracing the code and modify_ldt calls
| should show up.

I couldn't run this because my libc requires 2.6 kernels.

But I've managed to run wine with a game called 'Align-it!', and
I have the following result:

"""
~/tmp/ egrep -c 'modify_ldt' wine-strace.txt
46
~/tmp/
"""

I've checked the calls and none has failed. Not sure how good
this test is though.

Maybe it could be more tested in -mm?

| > Oh, btw, I forgot to 'quilt add arch/i386/mm/fault.c' [...]
|
| heh. After a dozen of such incidents i scripted my editor command to
| automatically do the quilt add :)

Oh, that's a good tip.

Thanks a lot,