From: Sam Ravnborg <sam@ravnborg.org>
To: Greg KH <gregkh@suse.de>
Cc: Nico Erfurth <masta@perlgolf.de>,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile
Date: Tue, 7 Aug 2007 06:13:45 +0200 [thread overview]
Message-ID: <20070807041345.GB1971@uranus.ravnborg.org> (raw)
In-Reply-To: <20070807030156.GB14310@suse.de>
On Mon, Aug 06, 2007 at 08:01:56PM -0700, Greg KH wrote:
> On Thu, Aug 02, 2007 at 11:27:01PM +0200, Sam Ravnborg wrote:
> > On Thu, Aug 02, 2007 at 10:25:20PM +0200, Nico Erfurth wrote:
> > > This patch adds the new iowarrior module to the Makefile in drivers/usb.
> > > Currently the module isn't build unless another driver from usb/misc is
> > > selected.
> >
> > Can we please just always vist misc like this:
> > obj-y := misc/
> >
> > Then we do not need to repeat this stuff in both
> > drivers/usb/Makefile and drivers/usb/misc/Makefile
>
> For some reason, we didn't do that because people were upset at us going
> into these directories when they didn't have any usb misc devices
> selected? Or something like that, I really can't remember anymore.
>
> But if you think it would be best to do that, I'd be glad to make the
> change.
Please do - we have too much duplication between the two files now.
Sam
prev parent reply other threads:[~2007-08-07 4:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 20:25 [PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile Nico Erfurth
2007-08-02 21:27 ` Sam Ravnborg
2007-08-07 3:01 ` Greg KH
2007-08-07 4:13 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807041345.GB1971@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=masta@perlgolf.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox