From: Andrew Morton <akpm@linux-foundation.org>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: turn serial console suspend a boot rather than compile time option
Date: Wed, 8 Aug 2007 16:13:45 -0700 [thread overview]
Message-ID: <20070808161345.4733b656.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070808190713.b59c9b00.dilinger@queued.net>
On Wed, 8 Aug 2007 19:07:13 -0400
Andres Salomon <dilinger@queued.net> wrote:
> On Wed, 8 Aug 2007 15:41:30 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Wed, 8 Aug 2007 18:35:35 -0400
> > Andres Salomon <dilinger@queued.net> wrote:
> >
> [...]
> > > --- a/include/linux/kernel.h
> > > +++ b/include/linux/kernel.h
> > > @@ -172,6 +172,8 @@ extern int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst);
> > > extern bool printk_timed_ratelimit(unsigned long *caller_jiffies,
> > > unsigned int interval_msec);
> > >
> > > +extern int console_suspend;
> > > +
> >
> > That's a somewhat vague-sounding identifier. Could we call it
> > console_suspend_enabled or something?
> >
>
> Hm, how about serial_console_suspend_enabled or enable_serial_console_suspend? I can send an updated patch later.
>
I prefer the big-endian version (serial_console_suspend_enabled)
next prev parent reply other threads:[~2007-08-08 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 22:35 [PATCH] serial: turn serial console suspend a boot rather than compile time option Andres Salomon
2007-08-08 22:41 ` Andrew Morton
2007-08-08 23:07 ` Andres Salomon
2007-08-08 23:13 ` Andrew Morton [this message]
2007-08-09 19:18 ` Andres Salomon
2007-08-14 7:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808161345.4733b656.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox