public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Aaron Durbin" <adurbin@google.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer
Date: Thu, 9 Aug 2007 02:50:43 +0200	[thread overview]
Message-ID: <200708090250.43467.ak@suse.de> (raw)
In-Reply-To: <8f95bb250708081744le5e5216k13087d05211a4056@mail.gmail.com>


> 
> I was thinking along the same lines as well, but I really didn't know how
> important all that code was for waiting for the next irq slice. I'm not time
> expert, but I would imagine we would resynchronize correctly in the future after
> this code path?

The idea is to just have the apic timers roughly at the same times + some fixed
offset as the main timer.  Otherwise e.g. add_timer could jitter up to a jiffie
regarding the jiffies counter. But long term drift will destroy the synchronization 
anyways.

I guess i'll send it in anyways for .23; it would be too risky to change anything 
radical in this area that late. Then later it can be revisited.

-Andi 



  reply	other threads:[~2007-08-09  0:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-08 23:17 [PATCH] x86_64: Avoid NMI Watchdog and/or long wait in setup_APIC_timer Aaron Durbin
2007-08-09  0:26 ` Andi Kleen
2007-08-09  0:44   ` Aaron Durbin
2007-08-09  0:50     ` Andi Kleen [this message]
2007-08-09 20:30 ` Andrew Morton
2007-08-09 21:16   ` Aaron Durbin
2007-08-09 21:56     ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2007-08-09  3:45 Aaron Durbin
2007-08-08 23:08 Aaron Durbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708090250.43467.ak@suse.de \
    --to=ak@suse.de \
    --cc=adurbin@google.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox