* [PATCH] Remove x86_cpu_to_log_apicid
@ 2007-08-08 21:01 Christoph Lameter
2007-08-09 1:34 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2007-08-08 21:01 UTC (permalink / raw)
To: ak; +Cc: linux-kernel, travis
From: Mike Travis <travis@sgi.com>
Remove the x86_cpu_to_log_apicid array. It is set in
arch/x86_64/kernel/genapic_flat.c:flat_init_apic_ldr() and
arch/x86_64/kernel/smpboot.c:do_boot_cpu() but it is never
referenced.
Signed-off-by: Mike Travis <travis@sgi.com>
---
arch/x86_64/kernel/genapic.c | 2 --
arch/x86_64/kernel/genapic_flat.c | 1 -
arch/x86_64/kernel/smpboot.c | 1 -
include/asm-x86_64/smp.h | 1 -
4 files changed, 5 deletions(-)
--- a/arch/x86_64/kernel/genapic.c
+++ b/arch/x86_64/kernel/genapic.c
@@ -29,8 +29,6 @@
= { [0 ... NR_CPUS-1] = BAD_APICID };
EXPORT_SYMBOL(x86_cpu_to_apicid);
-u8 x86_cpu_to_log_apicid[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
-
struct genapic __read_mostly *genapic = &apic_flat;
/*
--- a/arch/x86_64/kernel/genapic_flat.c
+++ b/arch/x86_64/kernel/genapic_flat.c
@@ -52,7 +52,6 @@
num = smp_processor_id();
id = 1UL << num;
- x86_cpu_to_log_apicid[num] = id;
apic_write(APIC_DFR, APIC_DFR_FLAT);
val = apic_read(APIC_LDR) & ~APIC_LDR_MASK;
val |= SET_APIC_LOGICAL_ID(id);
--- a/arch/x86_64/kernel/smpboot.c
+++ b/arch/x86_64/kernel/smpboot.c
@@ -702,7 +702,6 @@
cpu_clear(cpu, cpu_present_map);
cpu_clear(cpu, cpu_possible_map);
x86_cpu_to_apicid[cpu] = BAD_APICID;
- x86_cpu_to_log_apicid[cpu] = BAD_APICID;
return -EIO;
}
--- a/include/asm-x86_64/smp.h
+++ b/include/asm-x86_64/smp.h
@@ -84,7 +84,6 @@
* the real APIC ID <-> CPU # mapping.
*/
extern u8 x86_cpu_to_apicid[NR_CPUS]; /* physical ID */
-extern u8 x86_cpu_to_log_apicid[NR_CPUS];
extern u8 bios_cpu_apicid[];
static inline int cpu_present_to_apicid(int mps_cpu)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove x86_cpu_to_log_apicid
2007-08-08 21:01 [PATCH] Remove x86_cpu_to_log_apicid Christoph Lameter
@ 2007-08-09 1:34 ` Andi Kleen
2007-08-09 4:22 ` Christoph Lameter
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2007-08-09 1:34 UTC (permalink / raw)
To: Christoph Lameter; +Cc: linux-kernel, travis
On Wednesday 08 August 2007 23:01, Christoph Lameter wrote:
> From: Mike Travis <travis@sgi.com>
Why does Mike not submit his patches by himself?
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove x86_cpu_to_log_apicid
2007-08-09 1:34 ` Andi Kleen
@ 2007-08-09 4:22 ` Christoph Lameter
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2007-08-09 4:22 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel, travis
On Thu, 9 Aug 2007, Andi Kleen wrote:
> On Wednesday 08 August 2007 23:01, Christoph Lameter wrote:
> > From: Mike Travis <travis@sgi.com>
>
> Why does Mike not submit his patches by himself?
Its his first patch and I wanted to help out a bit .... He will submit
them himself in the future.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-09 4:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-08 21:01 [PATCH] Remove x86_cpu_to_log_apicid Christoph Lameter
2007-08-09 1:34 ` Andi Kleen
2007-08-09 4:22 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox