From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: linux-kernel@vger.kernel.org, drfickle@us.ibm.com, mel@csn.ul.ie,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: 2.6.23-rc2-mm1 -- PPC G5 kernel compile failure
Date: Thu, 9 Aug 2007 14:04:49 +0100 [thread overview]
Message-ID: <20070809130449.GB3091@shadowen.org> (raw)
In-Reply-To: <20070809015106.cd0bfc53.akpm@linux-foundation.org>
Seeing the following compile error on a G5 mac:
drivers/video/tdfxfb.c: In function 'tdfxfb_setup':
drivers/video/tdfxfb.c:1341: error: 'opt' undeclared (first use in this
function)
drivers/video/tdfxfb.c:1341: error: (Each undeclared identifier is
reported only once
drivers/video/tdfxfb.c:1341: error: for each function it appears in.)
This seems to be the following fragment from tdfxfb-hardware-cursor:
+ } else if (!strcmp(this_opt, "hwcursor")) {
+ hwcursor = simple_strtoul(opt + 9, NULL, 0);
I guess the nieve fix would be s/opt/this_opt, but I am also
suspicious of the +9 here as hwcursor is only 8 long? Now this
seems to take a numeric value and I assume that is via hwcursor=N,
if so then the +9 would make sense _if_ the strcmp was against
"hwcursor=".
Krzysztof?
-apw
next prev parent reply other threads:[~2007-08-09 13:05 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 8:51 2.6.23-rc2-mm1 Andrew Morton
2007-08-09 10:10 ` [usb-storage] schedule_timeout: wrong timeout value c1a95554 Mariusz Kozlowski
2007-08-09 14:43 ` [linux-usb-devel] " Alan Stern
2007-08-09 15:07 ` Rafael J. Wysocki
2007-08-09 15:20 ` Mariusz Kozlowski
2007-08-09 19:15 ` Rafael J. Wysocki
2007-08-09 12:53 ` 2.6.23-rc2-mm1 -- spinlock bad magic Andy Whitcroft
2007-08-09 17:17 ` Andy Whitcroft
2007-08-09 13:04 ` Andy Whitcroft [this message]
2007-08-09 14:20 ` 2.6.23-rc2-mm1 -- PPC G5 kernel compile failure (patch) Krzysztof Helt
2007-08-09 17:18 ` Andy Whitcroft
2007-08-10 13:09 ` Andy Whitcroft
2007-08-09 13:23 ` 2.6.23-rc2-mm1 Michal Piotrowski
2007-08-09 18:37 ` 2.6.23-rc2-mm1 Andrew Morton
2007-08-09 19:04 ` 2.6.23-rc2-mm1 Michal Piotrowski
2007-08-09 19:10 ` 2.6.23-rc2-mm1 Andrew Morton
2007-08-09 19:27 ` 2.6.23-rc2-mm1 Jeff Garzik
2007-08-09 13:51 ` 2.6.23-rc2-mm1: e1000e global symbols must be renamed Adrian Bunk
2007-08-09 17:06 ` [E1000-devel] " Kok, Auke
2007-08-09 14:24 ` 2.6.23-rc2-mm1: no bcm43xx Rafael J. Wysocki
2007-08-09 14:16 ` Michael Buesch
2007-08-09 15:11 ` 2.6.23-rc2-mm1: kernel BUG at mm/swap_state.c:78! Mariusz Kozlowski
2007-08-09 15:14 ` Adrian Bunk
2007-08-09 15:25 ` Mariusz Kozlowski
2007-08-09 15:37 ` Hugh Dickins
2007-08-09 16:00 ` Michal Piotrowski
2007-08-10 0:30 ` Nick Piggin
2007-08-09 15:36 ` 2.6.23-rc2-mm1 Michal Piotrowski
2007-08-09 16:19 ` 2.6.23-rc2-mm1 Michal Piotrowski
2007-08-09 17:04 ` 2.6.23-rc2-mm1 Andrew Morton
2007-08-09 16:31 ` 2.6.23-rc2-mm1 Andrew Morton
2007-08-09 20:17 ` 2.6.23-rc2-mm1: silly df numbers on 32bit extN Hugh Dickins
2007-08-09 20:56 ` Andrew Morton
2007-08-09 20:30 ` 2.6.23-rc2-mm1 Jesper Juhl
2007-08-09 21:36 ` 2.6.23-rc2-mm1 Gabriel C
2007-08-09 22:04 ` 2.6.23-rc2-mm1 Andrew Morton
2007-08-09 22:42 ` 2.6.23-rc2-mm1 Alan Cox
2007-08-09 23:33 ` 2.6.23-rc2-mm1 Gabriel C
2007-08-09 23:23 ` 2.6.23-rc2-mm1: sleeping function called from invalid context at kernel/mutex.c:86 Mariusz Kozlowski
2007-08-10 0:11 ` Andrew Morton
2007-08-10 5:36 ` Josh Triplett
2007-08-10 7:27 ` Mariusz Kozlowski
2007-08-10 7:40 ` Ingo Molnar
2007-08-10 7:55 ` Andrew Morton
2007-08-11 7:24 ` Alexey Dobriyan
2007-08-09 23:49 ` 2.6.23-rc2-mm1: rtl8139 inconsistent lock state Mariusz Kozlowski
2007-08-22 13:35 ` [PATCH 2.6.23-rc3-mm1] request_irq fix DEBUG_SHIRQ handling " Jarek Poplawski
2007-08-25 9:43 ` Mariusz Kozlowski
2007-08-27 5:54 ` Jarek Poplawski
2007-08-23 8:44 ` [PATCH (take 2)] " Jarek Poplawski
2007-08-24 5:46 ` Jarek Poplawski
2007-08-10 1:31 ` 2.6.23-rc2-mm1: rcutorture xtime usage Adrian Bunk
2007-08-10 2:00 ` Paul E. McKenney
2007-08-10 2:06 ` Andrew Morton
2007-08-10 15:12 ` Paul E. McKenney
2007-08-10 17:12 ` Andrew Morton
2007-08-10 20:30 ` Paul E. McKenney
2007-08-11 0:29 ` Paul E. McKenney
2007-08-11 4:47 ` Paul E. McKenney
2007-08-11 18:09 ` Ingo Molnar
2007-08-11 19:39 ` Paul E. McKenney
2007-08-10 2:22 ` Adrian Bunk
2007-08-10 7:06 ` 2.6.23-rc2-mm1: irq lock inversion dependency detected Mariusz Kozlowski
2007-08-24 8:27 ` Jarek Poplawski
2007-08-24 8:50 ` Jarek Poplawski
2007-08-14 21:22 ` [-mm patch] make fs/nfsd/nfs4callback.c:do_probe_callback() static Adrian Bunk
2007-08-14 22:02 ` J. Bruce Fields
2007-08-14 21:23 ` [-mm patch] make drivers/ata/libata-scsi.c:ata_scsi_link_pm_policy() static Adrian Bunk
2007-08-14 21:23 ` [-mm patch] unexport ide_acpi_set_state Adrian Bunk
2007-08-14 21:23 ` [-mm patch] drivers/mtd/mtdbdi.c is no longer an own module Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809130449.GB3091@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=drfickle@us.ibm.com \
--cc=krzysztof.h1@wp.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox