Re: 2.4.XX and JMicron

[Willy Tarreau <w@1wt.eu>]

Hi Ivaylo,

On Thu, Aug 09, 2007 at 03:54:30PM +0300, ivaylo@bglans.net wrote:
> 
> Hello,
> 
> I have ASUS P5B-VM DO mobo with JMicron SATA/PATA controler. I write mail 
> to Alan Cox and he told me that PATA part of JMicron controler can be 
> pressant as generic ide. So I make some changes to generic ide driver in 
> kernel 2.4.35 to be support JMicron PATA controler, but I'm not advanced 
> in C programing and not sure what I did is right. It works for me.
> 
> If there are any interes I send you (see bellow) changes.

Your patch looks good to me. I'm queuing it for 2.4.36.
BTW, just for your info, you should always create your patch with diff -u
one directory above linux, so that we apply them with patch -p1. You don't
need to resend it, it's small enough for me to fix it by hand.

Thanks,
Willy

> 
> Best Regards.
> Ivaylo Josifov
> 
> --- /home/ivaylo/boza/linux-2.4.35/include/linux/pci_ids.h      2007-07-26 
> 23:53:41.000000000 +0300
> +++ include/linux/pci_ids.h     2007-08-02 19:51:18.000000000 +0300 @@ 
> -2100,3 +2100,7 @@
> 
>  #define PCI_VENDOR_ID_WORKBIT          0x1145
>  #define PCI_DEVICE_ID_WORKBIT_CB       0xf021
> +
> +#define PCI_VENDOR_ID_JMICRON          0x197b
> +#define PCI_DEVICE_ID_JMICRON_20363    0x2363
> +
> 
> 
> --- /home/ivaylo/boza/linux-2.4.35/drivers/ide/pci/generic.h    2007-07-26 
> 23:53:41.000000000 +0300
> +++ drivers/ide/pci/generic.h   2007-08-02 19:58:53.000000000 +0300 @@ 
> -157,6 +157,16 @@
>                 .channels       = 2,
>                 .autodma        = NOAUTODMA,
>                 .bootable       = ON_BOARD,
> +       },{     /* 12 */
> +               .vendor         = PCI_VENDOR_ID_JMICRON,
> +               .device         = PCI_DEVICE_ID_JMICRON_20363,
> +               .name           = "JMICRON_20363",
> +               .init_chipset   = init_chipset_generic,
> +               .init_hwif      = init_hwif_generic,
> +               .init_dma       = init_dma_generic,
> +               .channels       = 1,
> +               .autodma        = NOAUTODMA,
> +               .bootable       = ON_BOARD,
>         },{
>                 .vendor         = 0,
>                 .device         = 0,
> 
> 
> --- /home/ivaylo/boza/linux-2.4.35/drivers/ide/pci/generic.c    2007-07-26 
> 23:53:41.000000000 +0300
> +++ drivers/ide/pci/generic.c   2007-08-02 19:51:15.000000000 +0300 @@ 
> -143,6 +143,7 @@
>         { PCI_VENDOR_ID_TOSHIBA, PCI_DEVICE_ID_TOSHIBA_PICCOLO,PCI_ANY_ID, 
>         PCI_ANY_ID, 0, 0, 9},
>         { PCI_VENDOR_ID_TOSHIBA, 
>         PCI_DEVICE_ID_TOSHIBA_PICCOLO_1,PCI_ANY_ID, PCI_ANY_ID, 0, 0, 10},
>         { PCI_VENDOR_ID_TOSHIBA, 
>         PCI_DEVICE_ID_TOSHIBA_PICCOLO_2,PCI_ANY_ID, PCI_ANY_ID, 0, 0, 11},
> +       { PCI_VENDOR_ID_JMICRON, PCI_DEVICE_ID_JMICRON_20363,PCI_ANY_ID, 
> PCI_ANY_ID, 0, 0, 12},
>         { 0, },
>  };
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/