* Re: + sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch added to -mm tree [not found] <200708100141.l7A1ftnd029565@imap1.linux-foundation.org> @ 2007-08-10 8:18 ` Alexey Dobriyan 2007-08-10 9:26 ` Eric W. Biederman 0 siblings, 1 reply; 3+ messages in thread From: Alexey Dobriyan @ 2007-08-10 8:18 UTC (permalink / raw) To: akpm; +Cc: linux-kernel, ebiederm > @@ -1124,7 +1118,6 @@ static struct ctl_table fs_table[] = { > .proc_handler = &proc_dointvec, > }, > { > - .ctl_name = FS_NRFILE, > .procname = "file-nr", > .data = &files_stat, > .maxlen = 3*sizeof(int), Why? It will work just fine through default sysctl(2) writeback. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch added to -mm tree 2007-08-10 8:18 ` + sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch added to -mm tree Alexey Dobriyan @ 2007-08-10 9:26 ` Eric W. Biederman 2007-08-10 9:53 ` Alexey Dobriyan 0 siblings, 1 reply; 3+ messages in thread From: Eric W. Biederman @ 2007-08-10 9:26 UTC (permalink / raw) To: Alexey Dobriyan; +Cc: akpm, linux-kernel Alexey Dobriyan <adobriyan@sw.ru> writes: >> @@ -1124,7 +1118,6 @@ static struct ctl_table fs_table[] = { >> .proc_handler = &proc_dointvec, >> }, >> { >> - .ctl_name = FS_NRFILE, >> .procname = "file-nr", >> .data = &files_stat, >> .maxlen = 3*sizeof(int), > > Why? It will work just fine through default sysctl(2) writeback. Well write doesn't happen. But even more so proc_nr_files() dynamically generates files_stat.nr_files. That doesn't happen on the generic sysctl path, and thus it's broken. Yes. I'm being picky, because at some point in the past before that was a per cpu variable the code worked, and won't look broken now unless you examine the contents of the data. Eric ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch added to -mm tree 2007-08-10 9:26 ` Eric W. Biederman @ 2007-08-10 9:53 ` Alexey Dobriyan 0 siblings, 0 replies; 3+ messages in thread From: Alexey Dobriyan @ 2007-08-10 9:53 UTC (permalink / raw) To: Eric W. Biederman; +Cc: akpm, linux-kernel, dipankar On Fri, Aug 10, 2007 at 03:26:52AM -0600, Eric W. Biederman wrote: > Alexey Dobriyan <adobriyan@sw.ru> writes: > > >> @@ -1124,7 +1118,6 @@ static struct ctl_table fs_table[] = { > >> .proc_handler = &proc_dointvec, > >> }, > >> { > >> - .ctl_name = FS_NRFILE, > >> .procname = "file-nr", > >> .data = &files_stat, > >> .maxlen = 3*sizeof(int), > > > > Why? It will work just fine through default sysctl(2) writeback. > > > Well write doesn't happen. But even more so proc_nr_files() dynamically > generates files_stat.nr_files. That doesn't happen on the generic > sysctl path, and thus it's broken. I see now, thanks. CC'ing Dipankar who probably want to fix this. Dipankar, fs.file-nr always contains stale data in nr_files field unless you regenerate it by reading /proc/sys/fs/file-nr :) > Yes. I'm being picky, because at some point in the past before > that was a per cpu variable the code worked, and won't look broken > now unless you examine the contents of the data. More than year passed, nobody noticed until now, probably FS_NRFILE should go. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-10 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200708100141.l7A1ftnd029565@imap1.linux-foundation.org>
2007-08-10 8:18 ` + sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch added to -mm tree Alexey Dobriyan
2007-08-10 9:26 ` Eric W. Biederman
2007-08-10 9:53 ` Alexey Dobriyan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox