Re: [patch 4/4] Switch to struct path in fs_struct

Christoph Hellwig
2007-08-29T19:12:35Z

On Fri, Aug 10, 2007 at 04:22:12PM +0200, Andreas Gruenbacher wrote:
> * Move the definition of struct path into <linux/path.h>.
>
> * Use struct path in fs_struct. This allows to use pathget and
> pathput on a fs_struct.

Looks good.

Btw, WTF are pnpbios and sound looking at fs_struct? They have no
right to poke there at all.

> --- /dev/null
> +++ b/include/linux/path.h
> @@ -0,0 +1,12 @@
> +#ifndef _LINUX_PATH_H
> +#define _LINUX_PATH_H
> +
> +struct dentry;
> +struct vfsmount;
> +
> +struct path {
> + struct vfsmount *mnt;
> + struct dentry *dentry;
> +};
> +
> +#endif /* _LINUX_PATH_H */

This header should probably also have the prototypes for pathget/pathput