Re: [patch 1/4] Introduce pathput

Christoph Hellwig
2007-08-29T19:07:27Z

On Fri, Aug 10, 2007 at 04:22:09PM +0200, Andreas Gruenbacher wrote:
> * Add pathput() for releasing a reference to the dentry and vfsmount of a
> struct path.
>
> * Switch from path_release(nd) to pathget(&nd->path).

^^^^^^^^^^^^^ pathput

>
> * Switch from path_release_on_umount(nd) to pathput_on_umount(&nd->path).
>
> * Rename dput_path() to pathput_conditional().

The introduction of pathput is fine we me. The removal of path_release
doesn't make much sense. We have tons of invocations of exactly that
patter, and having keeping path_release for that makes a lot of sense.

I also think there rename from dput_path to pathput_conditional is
rather pointless. Sure, that thing needs a better name, but
pathput_conditional is not a better name.

And all of the functions could use some kerneldoc comments describing them.