From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Miles Lane" <miles.lane@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"shannon.nelson@intel.com" <shannon.nelson@intel.com>,
"Luck, Tony" <tony.luck@intel.com>
Subject: Re: 2.6.23-rc2-mm1 -- drivers/dma/ioat_dca.c:177: error: implicit declaration of function ___cpu_physical_id___
Date: Fri, 10 Aug 2007 15:27:42 +0200 [thread overview]
Message-ID: <200708101527.42628.ak@suse.de> (raw)
In-Reply-To: <20070809115258.5372f76e.akpm@linux-foundation.org>
On Thursday 09 August 2007 20:52:58 Andrew Morton wrote:
> On Thu, 9 Aug 2007 10:18:15 -0400
> "Miles Lane" <miles.lane@gmail.com> wrote:
>
> > CC drivers/dma/ioat_dca.o
> > drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag':
> > drivers/dma/ioat_dca.c:177: error: implicit declaration of function
> > 'cpu_physical_id'
>
> Looks like cpu_physical_id() doesn't get implemented if CONFIG_SMP=n.
>
> Either ioat needs to stop using cpu_physical_id() if SMP=n, or the
> supported architectures (i386, x86_64, ia64) should provide a non-SMP
> version of cpu_physical_id(). Preferably the latter, I'd say.
It doesn't make much sense in smp.h because there is not really
a concept of physical id on most architectures i expect. Better
to put it into the individual asm files.
-Andi
next prev parent reply other threads:[~2007-08-10 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 14:18 2.6.23-rc2-mm1 -- drivers/dma/ioat_dca.c:177: error: implicit declaration of function ‘cpu_physical_id’ Miles Lane
2007-08-09 14:32 ` Adrian Bunk
2007-08-09 18:24 ` Miles Lane
2007-08-09 18:52 ` 2.6.23-rc2-mm1 -- drivers/dma/ioat_dca.c:177: error: implicit declaration of function ___cpu_physical_id___ Andrew Morton
2007-08-10 13:13 ` Miles Lane
2007-08-10 13:27 ` Andi Kleen [this message]
2007-08-10 16:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708101527.42628.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=shannon.nelson@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox