From: Andi Kleen <ak@suse.de>
To: jblunck@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] oprofile: Make callgraph use dump_trace() on i386/x86_64
Date: Fri, 10 Aug 2007 15:45:22 +0200 [thread overview]
Message-ID: <200708101545.22498.ak@suse.de> (raw)
In-Reply-To: <20070810133635.821996956@suse.de>
On Friday 10 August 2007 15:35:29 jblunck@suse.de wrote:
> This patch improves oprofile callgraphs for i386/x86_64. The old backtracing
> code was unable to produce even kernel backtraces if the kernel wasn't
> compiled with framepointers. The code now uses dump_trace().
Hmm one issue i didn't notice before: with imprecise backtrace
the profiling could be a little random because even if the same
call chain is hit repeatedly the garbage left over stack entries also
reported could vary and then cause oprofile to put it into different
buckets. But there is probably not much that can be
done about that.
-Andi
next prev parent reply other threads:[~2007-08-10 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 13:35 [PATCH 0/2] Improve Oprofile Callgraphs on i386/x86_64 jblunck
2007-08-10 13:35 ` [PATCH 1/2] oprofile: Make callgraph use dump_trace() " jblunck
2007-08-10 13:45 ` Andi Kleen [this message]
2007-08-10 14:11 ` Jan Blunck
2007-08-10 13:35 ` [PATCH 2/2] i386/x86_64: Introduce frame_pointer() and stack_pointer() jblunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708101545.22498.ak@suse.de \
--to=ak@suse.de \
--cc=jblunck@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox