From: Jean Delvare <khali@linux-fr.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.23-rc1 regression: hwmon/w83627ehf: wrong fan speed
Date: Sun, 12 Aug 2007 11:21:53 +0200 [thread overview]
Message-ID: <20070812112153.59454e84@hyperion.delvare> (raw)
In-Reply-To: <46BDDA59.5070302@s5r6.in-berlin.de>
On Sat, 11 Aug 2007 17:48:41 +0200, Stefan Richter wrote:
> Jean Delvare wrote:
>> So my theory is that something else (BIOS, ACPI?)
>
> (ksensors?)
ACPI if my guess is correct.
>> is changing the bank,
>> probably to read temperature values which are in banks 1 and 2, causing
>> the w83627ehf to get a wrong value for the VBAT register. If I am
>> right, then the attached patch should help. Please give it a try and
>> report.
>
> This patch fixes the issue. (I didn't reboot, only reloaded the drivers
> after patching.)
>
> Thanks for your help and advice.
Great, thanks for testing and reporting. Mark, please add my patch to
your hwmon-testing queue, and send it to Linus in the next batch of
fixes.
If no problem is reported, we can get rid of w83627ehf_reset_bank() in
a later kernel version.
--
Jean Delvare
next prev parent reply other threads:[~2007-08-12 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 11:20 2.6.23-rc1 regression: hwmon/w83627ehf: wrong fan speed Stefan Richter
2007-08-05 11:28 ` Stefan Richter
2007-08-05 13:55 ` Mark M. Hoffman
2007-08-05 14:51 ` Stefan Richter
2007-08-05 15:17 ` Mark M. Hoffman
2007-08-05 16:21 ` Mark M. Hoffman
2007-08-05 17:13 ` Stefan Richter
2007-08-10 21:08 ` Jean Delvare
2007-08-10 22:29 ` Stefan Richter
2007-08-10 22:39 ` Stefan Richter
2007-08-11 2:30 ` [lm-sensors] " David Hubbard
2007-08-11 11:57 ` Jean Delvare
2007-08-11 15:41 ` Stefan Richter
2007-08-11 15:48 ` Stefan Richter
2007-08-12 9:21 ` Jean Delvare [this message]
2007-08-12 9:17 ` Jean Delvare
2007-08-12 10:34 ` Stefan Richter
2007-08-12 10:43 ` Stefan Richter
2007-08-12 17:49 ` Mark M. Hoffman
2007-08-12 16:06 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070812112153.59454e84@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox