Re: 2.6.23-rc1 regression: hwmon/w83627ehf: wrong fan speed

Mark M. Hoffman
2007-08-12T17:53:47Z

Hi Jean:

* Jean Delvare <khali@linux-fr.org> [2007-08-11 13:57:05 +0200]:
> Don't assume that the default bank is 0. For one thing, we don't even
> set it to 0 when the driver is loaded, so the initial state might be
> different. For another, something (say, the BIOS) might access the chip
> and leave with the bank set to something different, so assuming that
> the bank value is 0 is not safe.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> drivers/hwmon/w83627ehf.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> --- linux-2.6.23-rc2.orig/drivers/hwmon/w83627ehf.c 2007-07-23 16:44:35.000000000 +0200
> +++ linux-2.6.23-rc2/drivers/hwmon/w83627ehf.c 2007-08-11 12:55:58.000000000 +0200
> @@ -309,18 +309,16 @@ static inline int is_word_sized(u16 reg)
> || (reg & 0x00ff) == 0x55));
> }
>
> -/* We assume that the default bank is 0, thus the following two functions do
> - nothing for registers which live in bank 0. For others, they respectively
> - set the bank register to the correct value (before the register is
> - accessed), and back to 0 (afterwards). */
> +/* Registers 0x50-0x5f are banked */
> static inline void w83627ehf_set_bank(struct w83627ehf_data *data, u16 reg)
> {
> - if (reg & 0xff00) {
> + if ((reg & 0x00f0) == 0x50) {
> outb_p(W83627EHF_REG_BANK, data->addr + ADDR_REG_OFFSET);
> outb_p(reg >> 8, data->addr + DATA_REG_OFFSET);
> }
> }
>
> +/* Not strictly necessary, but play it safe for now */
> static inline void w83627ehf_reset_bank(struct w83627ehf_data *data, u16 reg)
> {
> if (reg & 0xff00) {

Applied to hwmon-2.6.git/testing, thanks.

--
Mark M. Hoffman
mhoffman@lightlink.com