Re: 2.6.23-rc1 regression: hwmon/w83627ehf: wrong fan speed

Jean Delvare
2007-08-12T09:24:31Z

On Sat, 11 Aug 2007 17:48:41 +0200, Stefan Richter wrote:
> Jean Delvare wrote:
>> So my theory is that something else (BIOS, ACPI?)
>
> (ksensors?)

ACPI if my guess is correct.

>> is changing the bank,
>> probably to read temperature values which are in banks 1 and 2, causing
>> the w83627ehf to get a wrong value for the VBAT register. If I am
>> right, then the attached patch should help. Please give it a try and
>> report.
>
> This patch fixes the issue. (I didn't reboot, only reloaded the drivers
> after patching.)
>
> Thanks for your help and advice.

Great, thanks for testing and reporting. Mark, please add my patch to
your hwmon-testing queue, and send it to Linus in the next batch of
fixes.

If no problem is reported, we can get rid of w83627ehf_reset_bank() in
a later kernel version.

--
Jean Delvare