From: Sergey Dolgov <solkaa@gmail.com>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Hugh Dickins <hugh@veritas.com>, Sergey Dolgov <solkaa@gmail.com>,
Len Brown <len.brown@intel.com>,
Norbert Preining <preining@logic.at>,
Linus Torvalds <torvalds@linux-foundation.org>,
Henrique de Moraes Holshuh <hmh@hmh.eng.br>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.23-rc3 regression and bisection query
Date: Tue, 14 Aug 2007 11:54:51 +0400 [thread overview]
Message-ID: <20070814075422.GA2586@slk.laptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0708132353480.6269@blonde.wat.veritas.com>
On Mon, Aug 13, 2007 at 11:56:22PM +0100, Hugh Dickins wrote:
> On Tue, 14 Aug 2007, Alexey Starikovskiy wrote:
> > Sergey Dolgov wrote:
> > > On Mon, Aug 13, 2007 at 07:44:48PM +0100, Hugh Dickins wrote:
> > >
> > >> Git bisection (with manual fixups to i386 mmiocfg horror, thanks
> > >> for drawing attention to that in your changelog) accuses Alexey's
> > >> ACPI: EC: If ECDT is not found, look up EC in DSDT
> > >> cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
> > >> and if I revert that along with Len's subsequent
> > >> ACPI: EC: fix build warning
> > >> 52fe4bdf40bc07498c5f7935551774e8f8458190
> > >> then I have Fn-F4 suspending to RAM again.
> > >
> > > I've also noticed a regression since -rc2 in battery status reporting
> > > on my HP nx7300 laptop: the output of
> > >
> > > cat /proc/acpi/battery/C1BE/state
> > >
> > > does not change after this file has been read for the the first time;
> > > for exaple, the line "charging state: charged" does not change to
> > > "charging state: discharging" upon unplugging the power cord.
> > >
> > > Reverting the above 2 commits fixes this issue for me.
> > >
> > > --
> > > Sergey
> > >
> > Function to register query methods (means by which EC talks to ACPI)
> > was deleted by mistake.
> >
> > Could you please try the attached patch?
>
> Great, that indeed fixes my Thinkpad suspend-to-RAM cases
> (both the Fn-F4, and resume from echo mem >/sys/power/state):
> thanks a lot, Alexey.
Same thing here, your patch ontop of -rc3 fixes battery status
reporting for me.
Thanks, Alexey.
--
Sergey
next prev parent reply other threads:[~2007-08-14 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 18:44 2.6.23-rc3 regression and bisection query Hugh Dickins
2007-08-13 20:29 ` Michal Piotrowski
2007-08-13 21:22 ` Sergey Dolgov
2007-08-13 22:10 ` Alexey Starikovskiy
2007-08-13 22:56 ` Hugh Dickins
2007-08-14 7:54 ` Sergey Dolgov [this message]
[not found] ` <46C0D35B.5030104@suse.de>
2007-08-14 7:09 ` [Fwd: Re: 2.6.23-rc3 regression and bisection query] Norbert Preining
2007-08-14 16:18 ` Len Brown
2007-08-14 16:33 ` Norbert Preining
2007-08-14 16:41 ` Alexey Starikovskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070814075422.GA2586@slk.laptop \
--to=solkaa@gmail.com \
--cc=astarikovskiy@suse.de \
--cc=hmh@hmh.eng.br \
--cc=hugh@veritas.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=preining@logic.at \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox