From: Alasdair G Kergon <agk@redhat.com>
To: Diego Woitasen <diego@woitasen.com.ar>
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove unneded lock_kernel in drivers/md/dm.c and use unlocked_ioctl.
Date: Tue, 14 Aug 2007 21:12:20 +0100 [thread overview]
Message-ID: <20070814201220.GA30122@agk.fab.redhat.com> (raw)
In-Reply-To: <11858486294133-git-send-email-diego@woitasen.com.ar>
On Mon, Jul 30, 2007 at 11:23:49PM -0300, Diego Woitasen wrote:
> -static int dm_blk_ioctl(struct inode *inode, struct file *file,
> - unsigned int cmd, unsigned long arg)
> +static long dm_blk_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> - /* We don't really need this lock, but we do need 'inode'. */
> - unlock_kernel();
> + inode = file->f_path.dentry->d_inode;
Have the call paths that pass a NULL 'file' parameter down all been
changed? If not, perhaps pass the 'inode' parameter into
unlocked_ioctl(), as happens with ioctl(), to get rid of the lock.
Alasdair
--
agk@redhat.com
prev parent reply other threads:[~2007-08-14 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 2:23 [PATCH] remove unneded lock_kernel in drivers/md/dm.c and use unlocked_ioctl Diego Woitasen
2007-08-14 20:12 ` Alasdair G Kergon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070814201220.GA30122@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=diego@woitasen.com.ar \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox