[2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()

[2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()

[Adrian Bunk]

This patch #if 0's the unused dma_async_memcpy_buf_to_buf().

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/dma/dmaengine.c   |    2 ++
 include/linux/dmaengine.h |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

b91933344bed48adf2b64ca0f98c45b92ef69b79 
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 8248992..f0cda56 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -459,6 +459,7 @@ void dma_async_device_unregister(struct dma_device *device)
 }
 EXPORT_SYMBOL(dma_async_device_unregister);
 
+#if 0
 /**
  * dma_async_memcpy_buf_to_buf - offloaded copy between virtual addresses
  * @chan: DMA channel to offload copy to
@@ -501,6 +502,7 @@ dma_async_memcpy_buf_to_buf(struct dma_chan *chan, void *dest,
 	return cookie;
 }
 EXPORT_SYMBOL(dma_async_memcpy_buf_to_buf);
+#endif  /*  0  */
 
 /**
  * dma_async_memcpy_buf_to_pg - offloaded copy from address to page
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index a3b6035..75bdd65 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -302,8 +302,6 @@ struct dma_device {
 void dma_async_client_register(struct dma_client *client);
 void dma_async_client_unregister(struct dma_client *client);
 void dma_async_client_chan_request(struct dma_client *client);
-dma_cookie_t dma_async_memcpy_buf_to_buf(struct dma_chan *chan,
-	void *dest, void *src, size_t len);
 dma_cookie_t dma_async_memcpy_buf_to_pg(struct dma_chan *chan,
 	struct page *page, unsigned int offset, void *kdata, size_t len);
 dma_cookie_t dma_async_memcpy_pg_to_pg(struct dma_chan *chan,

[2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()

[Adrian Bunk]

This patch #if 0's the unused dma_async_memcpy_buf_to_buf().

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

This patch has been sent on:
- 14 Aug 2007

 drivers/dma/dmaengine.c   |    2 ++
 include/linux/dmaengine.h |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

b91933344bed48adf2b64ca0f98c45b92ef69b79 
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 8248992..f0cda56 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -459,6 +459,7 @@ void dma_async_device_unregister(struct dma_device *device)
 }
 EXPORT_SYMBOL(dma_async_device_unregister);
 
+#if 0
 /**
  * dma_async_memcpy_buf_to_buf - offloaded copy between virtual addresses
  * @chan: DMA channel to offload copy to
@@ -501,6 +502,7 @@ dma_async_memcpy_buf_to_buf(struct dma_chan *chan, void *dest,
 	return cookie;
 }
 EXPORT_SYMBOL(dma_async_memcpy_buf_to_buf);
+#endif  /*  0  */
 
 /**
  * dma_async_memcpy_buf_to_pg - offloaded copy from address to page
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index a3b6035..75bdd65 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -302,8 +302,6 @@ struct dma_device {
 void dma_async_client_register(struct dma_client *client);
 void dma_async_client_unregister(struct dma_client *client);
 void dma_async_client_chan_request(struct dma_client *client);
-dma_cookie_t dma_async_memcpy_buf_to_buf(struct dma_chan *chan,
-	void *dest, void *src, size_t len);
 dma_cookie_t dma_async_memcpy_buf_to_pg(struct dma_chan *chan,
 	struct page *page, unsigned int offset, void *kdata, size_t len);
 dma_cookie_t dma_async_memcpy_pg_to_pg(struct dma_chan *chan,

Re: [2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()

[Alan Cox]

On Tue, 1 Jan 2008 15:49:24 +0200
Adrian Bunk <bunk@kernel.org> wrote:

> This patch #if 0's the unused dma_async_memcpy_buf_to_buf().
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

NAK. Yet again you are trying to remove bits of APIs in ways that make
no sense.

RE: [2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()

[Nelson, Shannon]

>From: Alan Cox [mailto:alan@lxorguk.ukuu.org.uk] 
>Sent: Tuesday, January 01, 2008 6:26 AM
>To: Adrian Bunk
>Cc: Nelson, Shannon; Williams, Dan J; linux-kernel@vger.kernel.org
>Subject: Re: [2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()
>
>On Tue, 1 Jan 2008 15:49:24 +0200
>Adrian Bunk <bunk@kernel.org> wrote:
>
>> This patch #if 0's the unused dma_async_memcpy_buf_to_buf().
>> 
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
>NAK. Yet again you are trying to remove bits of APIs in ways that make
>no sense.
>

Yes, this should be a NAK.

Thank you Alan.

sln