* [2.6 patch] fix export_report.pl
@ 2007-08-14 21:22 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2007-08-14 21:22 UTC (permalink / raw)
To: Ram Pai, Sam Ravnborg; +Cc: linux-kernel
This patch fixes an annoying bug of export_report.pl missing the usages
of some exports.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
061222c0c3acfd3bbac143f4e31e09a0711bfeb8
diff --git a/scripts/export_report.pl b/scripts/export_report.pl
index 9ed00d9..08ceb42 100644
--- a/scripts/export_report.pl
+++ b/scripts/export_report.pl
@@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
next;
}
if ($state eq 2) {
- if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
+ if ( $_ !~ /0x[0-9a-f]+,/ ) {
next;
}
my $sym = (split /([,"])/,)[4];
^ permalink raw reply related [flat|nested] 6+ messages in thread* [2.6 patch] fix export_report.pl
@ 2007-08-24 21:04 Adrian Bunk
2007-08-24 21:36 ` Jan Engelhardt
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Adrian Bunk @ 2007-08-24 21:04 UTC (permalink / raw)
To: Andrew Morton, Ram Pai, Sam Ravnborg; +Cc: linux-kernel
This patch fixes an annoying bug of export_report.pl missing the usages
of some exports.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 14 Aug 2007
--- a/scripts/export_report.pl
+++ b/scripts/export_report.pl
@@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
next;
}
if ($state eq 2) {
- if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
+ if ( $_ !~ /0x[0-9a-f]+,/ ) {
next;
}
my $sym = (split /([,"])/,)[4];
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] fix export_report.pl
2007-08-24 21:04 Adrian Bunk
@ 2007-08-24 21:36 ` Jan Engelhardt
2007-08-24 21:47 ` Adrian Bunk
2007-08-24 21:40 ` Ram Pai
2007-08-25 10:51 ` Sam Ravnborg
2 siblings, 1 reply; 6+ messages in thread
From: Jan Engelhardt @ 2007-08-24 21:36 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, Ram Pai, Sam Ravnborg, linux-kernel
On Aug 24 2007 23:04, Adrian Bunk wrote:
>This patch fixes an annoying bug of export_report.pl missing the usages
>of some exports.
>
>Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
>---
>
>This patch has been sent on:
>- 14 Aug 2007
>
>--- a/scripts/export_report.pl
>+++ b/scripts/export_report.pl
>@@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
> next;
> }
> if ($state eq 2) {
Perl: == for numbers, eq for strings.
SH: == for strings, -eq for numbers.
PHP: == for everything.
>- if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
>+ if ( $_ !~ /0x[0-9a-f]+,/ ) {
I have not looked closer at it, but this looks like it should be
/0x[0-9a-fA-F]+,/ or
/0x[0-9a-f]+,/i
> next;
> }
> my $sym = (split /([,"])/,)[4];
>
Jan
--
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] fix export_report.pl
2007-08-24 21:36 ` Jan Engelhardt
@ 2007-08-24 21:47 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2007-08-24 21:47 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Andrew Morton, Ram Pai, Sam Ravnborg, linux-kernel
On Fri, Aug 24, 2007 at 11:36:40PM +0200, Jan Engelhardt wrote:
>
> On Aug 24 2007 23:04, Adrian Bunk wrote:
> >This patch fixes an annoying bug of export_report.pl missing the usages
> >of some exports.
> >
> >Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> >---
> >
> >This patch has been sent on:
> >- 14 Aug 2007
> >
> >--- a/scripts/export_report.pl
> >+++ b/scripts/export_report.pl
> >@@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
> > next;
> > }
> > if ($state eq 2) {
>
> Perl: == for numbers, eq for strings.
> SH: == for strings, -eq for numbers.
> PHP: == for everything.
I don't care whether it compares strings or numbers as long as it
works...
I'm not the author of this script, and my patch fixes the one annoying
bug I observed when using it.
Feel free to improve the script, but that's unrelated to my bugfix.
> >- if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
> >+ if ( $_ !~ /0x[0-9a-f]+,/ ) {
>
> I have not looked closer at it, but this looks like it should be
> /0x[0-9a-fA-F]+,/ or
> /0x[0-9a-f]+,/i
>...
You should have looked closer before sending your email.
> Jan
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] fix export_report.pl
2007-08-24 21:04 Adrian Bunk
2007-08-24 21:36 ` Jan Engelhardt
@ 2007-08-24 21:40 ` Ram Pai
2007-08-25 10:51 ` Sam Ravnborg
2 siblings, 0 replies; 6+ messages in thread
From: Ram Pai @ 2007-08-24 21:40 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, Sam Ravnborg, linux-kernel
On Fri, 2007-08-24 at 23:04 +0200, Adrian Bunk wrote:
> This patch fixes an annoying bug of export_report.pl missing the usages
> of some exports.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> This patch has been sent on:
> - 14 Aug 2007
>
> --- a/scripts/export_report.pl
> +++ b/scripts/export_report.pl
> @@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
> next;
> }
> if ($state eq 2) {
> - if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
> + if ( $_ !~ /0x[0-9a-f]+,/ ) {
> next;
> }
> my $sym = (split /([,"])/,)[4];
Adrian,
I am fine with these changes.
RP
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] fix export_report.pl
2007-08-24 21:04 Adrian Bunk
2007-08-24 21:36 ` Jan Engelhardt
2007-08-24 21:40 ` Ram Pai
@ 2007-08-25 10:51 ` Sam Ravnborg
2 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2007-08-25 10:51 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, Ram Pai, linux-kernel
On Fri, Aug 24, 2007 at 11:04:51PM +0200, Adrian Bunk wrote:
> This patch fixes an annoying bug of export_report.pl missing the usages
> of some exports.
Applied to kbuild.git plus Ram Pai's patch too.
Sam
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-08-25 10:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-14 21:22 [2.6 patch] fix export_report.pl Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2007-08-24 21:04 Adrian Bunk
2007-08-24 21:36 ` Jan Engelhardt
2007-08-24 21:47 ` Adrian Bunk
2007-08-24 21:40 ` Ram Pai
2007-08-25 10:51 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox