* [2.6 patch] drivers/char/n_hdlc.c: fix check-after-use
@ 2007-08-14 21:22 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2007-08-14 21:22 UTC (permalink / raw)
To: linux-kernel
The Coverity checker spotted that we'd have already oops'ed if "tty"
was NULL.
Since "tty" can't be NULL when we reach this line of code this patch
removes the NULL check.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
--- linux-2.6.23-rc1-mm2/drivers/char/n_hdlc.c.old 2007-08-08 06:11:02.000000000 +0200
+++ linux-2.6.23-rc1-mm2/drivers/char/n_hdlc.c 2007-08-08 06:11:15.000000000 +0200
@@ -220,25 +220,25 @@
static void n_hdlc_release(struct n_hdlc *n_hdlc)
{
struct tty_struct *tty = n_hdlc2tty (n_hdlc);
struct n_hdlc_buf *buf;
if (debuglevel >= DEBUG_LEVEL_INFO)
printk("%s(%d)n_hdlc_release() called\n",__FILE__,__LINE__);
/* Ensure that the n_hdlcd process is not hanging on select()/poll() */
wake_up_interruptible (&tty->read_wait);
wake_up_interruptible (&tty->write_wait);
- if (tty != NULL && tty->disc_data == n_hdlc)
+ if (tty->disc_data == n_hdlc)
tty->disc_data = NULL; /* Break the tty->n_hdlc link */
/* Release transmit and receive buffers */
for(;;) {
buf = n_hdlc_buf_get(&n_hdlc->rx_free_buf_list);
if (buf) {
kfree(buf);
} else
break;
}
for(;;) {
buf = n_hdlc_buf_get(&n_hdlc->tx_free_buf_list);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-14 21:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-14 21:22 [2.6 patch] drivers/char/n_hdlc.c: fix check-after-use Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox