Re: 2.6.23-rc2-mm1 -- PPC G5 kernel compile failure

Andy Whitcroft
2007-08-09T13:05:44Z

Seeing the following compile error on a G5 mac:

drivers/video/tdfxfb.c: In function 'tdfxfb_setup':
drivers/video/tdfxfb.c:1341: error: 'opt' undeclared (first use in this
function)
drivers/video/tdfxfb.c:1341: error: (Each undeclared identifier is
reported only once
drivers/video/tdfxfb.c:1341: error: for each function it appears in.)

This seems to be the following fragment from tdfxfb-hardware-cursor:

+ } else if (!strcmp(this_opt, "hwcursor")) {
+ hwcursor = simple_strtoul(opt + 9, NULL, 0);

I guess the nieve fix would be s/opt/this_opt, but I am also
suspicious of the +9 here as hwcursor is only 8 long? Now this
seems to take a numeric value and I assume that is via hwcursor=N,
if so then the +9 would make sense _if_ the strcmp was against
"hwcursor=".

Krzysztof?

-apw