From: Andi Kleen <ak@suse.de>
To: patches@x86-64.org, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: [PATCH] [3/4] x86_64: Change PMDS invocation to single macro
Date: Wed, 15 Aug 2007 02:40:36 +0200 (CEST) [thread overview]
Message-ID: <20070815004036.6BBCF14DC8@wotan.suse.de> (raw)
In-Reply-To: <20070815240.194452000@suse.de>
Very old binutils (2.12.90...) seem to have trouble with newlines
in assembler macro invocation. They put them into the resulting
argument expansion. In this case this lead to a parse error because
a .rept expression ended up spread over multiple lines. Change the PMDS()
invocation to a single line.
Signed-off-by: Andi Kleen <ak@suse.de>
Index: linux/arch/x86_64/kernel/head.S
===================================================================
--- linux.orig/arch/x86_64/kernel/head.S
+++ linux/arch/x86_64/kernel/head.S
@@ -345,8 +345,7 @@ NEXT_PAGE(level2_kernel_pgt)
/* 40MB kernel mapping. The kernel code cannot be bigger than that.
When you change this change KERNEL_TEXT_SIZE in page.h too. */
/* (2^48-(2*1024*1024*1024)-((2^39)*511)-((2^30)*510)) = 0 */
- PMDS(0x0000000000000000, __PAGE_KERNEL_LARGE_EXEC|_PAGE_GLOBAL,
- KERNEL_TEXT_SIZE/PMD_SIZE)
+ PMDS(0x0000000000000000, __PAGE_KERNEL_LARGE_EXEC|_PAGE_GLOBAL, KERNEL_TEXT_SIZE/PMD_SIZE)
/* Module mapping starts here */
.fill (PTRS_PER_PMD - (KERNEL_TEXT_SIZE/PMD_SIZE)),8,0
next prev parent reply other threads:[~2007-08-15 0:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 0:40 [PATCH] [0/4] More late merge bug fixes for 2.6.23 Andi Kleen
2007-08-15 0:40 ` [PATCH] [1/4] x86_64: Fail dma_alloc_coherent on dma less devices Andi Kleen
2007-08-18 17:22 ` Linus Torvalds
2007-08-18 19:03 ` Andi Kleen
2007-08-20 9:46 ` Takashi Iwai
2007-08-15 0:40 ` [PATCH] [2/4] x86_64: Fix to keep watchdog disabled by default for i386/x86_64 Andi Kleen
2007-08-15 0:40 ` Andi Kleen [this message]
2007-08-15 12:29 ` [PATCH] [3/4] x86_64: Change PMDS invocation to single macro Clemens Koller
2007-08-15 13:57 ` Andi Kleen
2007-08-15 0:40 ` [PATCH] [4/4] x86_64: Check for .cfi_rel_offset in CFI probe Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070815004036.6BBCF14DC8@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox