public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: mingo@elte.hu
Cc: nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: [patch] sched: fix broken smt/mc optimizations with CFS
Date: Wed, 15 Aug 2007 18:01:50 -0700	[thread overview]
Message-ID: <20070816010150.GG10033@linux-os.sc.intel.com> (raw)

Ingo, let me know if there any side effects of this change. Thanks.
---

On a four package system with HT - HT load balancing optimizations
were broken. For example, if two tasks end up running on two logical
threads of one of the packages, scheduler is not able to pull one of
the tasks to a completely idle package.

In this scenario, for nice-0 tasks, imbalance calculated by scheduler
will be 512 and find_busiest_queue() will return 0 (as each cpu's load
is 1024 > imbalance and has only one task running).

Similarly MC scheduler optimizations also get fixed with this patch.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---

diff --git a/kernel/sched.c b/kernel/sched.c
index 45e17b8..c5ac710 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2494,7 +2494,7 @@ group_next:
 	 * a think about bumping its value to force at least one task to be
 	 * moved
 	 */
-	if (*imbalance + SCHED_LOAD_SCALE_FUZZ < busiest_load_per_task/2) {
+	if (*imbalance < busiest_load_per_task) {
 		unsigned long tmp, pwr_now, pwr_move;
 		unsigned int imbn;
 

             reply	other threads:[~2007-08-16  1:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-16  1:01 Siddha, Suresh B [this message]
2007-08-23 10:38 ` [patch] sched: fix broken smt/mc optimizations with CFS Ingo Molnar
2007-08-23 11:54 ` Ingo Molnar
2007-08-23 12:13   ` Ingo Molnar
2007-08-23 17:42     ` Daniel Walker
2007-08-27 19:19     ` Siddha, Suresh B
2007-08-27 19:23       ` Ingo Molnar
2007-08-27 19:31         ` Siddha, Suresh B
2007-08-28 22:27           ` Siddha, Suresh B
2007-08-29  3:42             ` Ingo Molnar
2007-09-04 23:35             ` Chuck Ebbert
2007-09-04 23:46               ` Siddha, Suresh B
2007-09-05 10:51                 ` Ingo Molnar
2007-08-27 16:32   ` Torsten Kaiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070816010150.GG10033@linux-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox