From: Jens Axboe <jens.axboe@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-kernel@vger.kernel.org, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 000 of 5] Introductory patches for bio refactor.
Date: Thu, 16 Aug 2007 08:37:27 +0200 [thread overview]
Message-ID: <20070816063725.GD23758@kernel.dk> (raw)
In-Reply-To: <20070816150445.30843.patches@notabene>
On Thu, Aug 16 2007, NeilBrown wrote:
>
> Hi Jens,
> I wonder if you would accept these patches the block layer.
> They are, as far as I can tell, quite uncontroversial and provide
> good cleanups.
>
> The first is a minor bug-fix.
> The next to replace helper function that take a bio (always the first
> bio of a request), to instead take a request.
>
> The last two combine to replace rq_for_each_bio with
> rq_for_each_segment which makes blk_recalc_rq_segments a lot
> cleaner, and improves (to a lesser degree) every other place that
> used rq_for_each_bio.
>
> The net result is a decrease in object code size (for my x86-64 compile)
> for block/built-in.o of 96 bytes, though there is some growth out in
> drivers making and over-all decrease of only 48 bytes.
Thanks for seperating these out Neil, will go over them this morning!
--
Jens Axboe
prev parent reply other threads:[~2007-08-16 6:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 5:13 [PATCH 000 of 5] Introductory patches for bio refactor NeilBrown
2007-08-16 5:13 ` [PATCH 001 of 5] Don't update bi_hw_*_size if we aren't going to merge NeilBrown
2007-08-16 7:01 ` Jens Axboe
2007-08-16 5:13 ` [PATCH 002 of 5] Replace bio_data with blk_rq_data NeilBrown
2007-08-16 7:02 ` Jens Axboe
2007-08-16 7:15 ` Neil Brown
2007-08-16 7:21 ` Jens Axboe
2007-08-16 11:15 ` Neil Brown
2007-08-16 11:19 ` Jens Axboe
2007-08-16 11:22 ` Jens Axboe
2007-08-16 5:13 ` [PATCH 003 of 5] Replace bio_cur_sectors with blk_rq_cur_sectors NeilBrown
2007-08-16 5:13 ` [PATCH 004 of 5] Introduce rq_for_each_segment replacing rq_for_each_bio NeilBrown
2007-08-16 5:13 ` [PATCH 005 of 5] Merge blk_recount_segments into blk_recalc_rq_segments NeilBrown
2007-08-16 6:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070816063725.GD23758@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox