public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Andrew Morton <akpm@osdl.org>,
	stable@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
	Alberto Pires de Oliveira Neto <apon1@terra.com.br>,
	giedrius@su.lt
Subject: Re: [PATCH] UML - Add a .note.SuSE section
Date: Thu, 16 Aug 2007 22:04:55 +0200	[thread overview]
Message-ID: <20070816200455.GA14424@uranus.ravnborg.org> (raw)
In-Reply-To: <20070816192639.GA8957@c2.user-mode-linux.org>

On Thu, Aug 16, 2007 at 03:26:39PM -0400, Jeff Dike wrote:
> 
> The crash is in this section:
> 
>   __uml_setup_start = .;
>   .uml.setup.init : { *(.uml.setup.init) }
>   __uml_setup_end = .;

This looks like a classic bug.
You wanted this:
.uml.setup.init : {
	__uml_setup_start = .;
	*(.uml.setup.init)
	__uml_setup_end = .;
}

In this way you are sure __uml_setup_start has same address as start
of section.
With the original code the linker will align the .uml.setup.init section
to the alignment required by the included sections and thus
the label and the actual start address may differ.

	Sam

  reply	other threads:[~2007-08-16 20:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-16 16:24 [PATCH] UML - Add a .note.SuSE section Jeff Dike
2007-08-16 16:30 ` Arjan van de Ven
2007-08-16 16:54   ` [stable] " Greg KH
2007-08-16 19:26   ` Jeff Dike
2007-08-16 20:04     ` Sam Ravnborg [this message]
2007-08-16 21:05       ` Jeff Dike
2007-08-21 17:05         ` [uml-devel] " Blaisorblade
2007-08-22 16:37           ` Jeff Dike
2007-08-23 14:50             ` Blaisorblade
2007-08-16 16:39 ` [stable] " Chris Wright
2007-08-16 19:30 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070816200455.GA14424@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=apon1@terra.com.br \
    --cc=arjan@infradead.org \
    --cc=giedrius@su.lt \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox