From: David Brownell <david-b@pacbell.net>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
jengelh@computergmbh.de, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware
Date: Fri, 17 Aug 2007 21:06:51 -0700 [thread overview]
Message-ID: <200708172106.52940.david-b@pacbell.net> (raw)
In-Reply-To: <1187404839.4419.5.camel@lov.localdomain>
On Friday 17 August 2007, Kay Sievers wrote:
>
> > I'm not the one who's advocating a change here. If you want to
> > first change/break and then fix things, all of that is up to you.
>
> I'm happy to do that. Patch is attached.
NAK. That wasn't even a serious attempt at the "fix" part,
though it does the "break" part well enough to cause severe
regressions.
(As well as leaving all my technical points about your pushback
un-addressed. As I noted before, the evident fact that you don't
have technical responses to them says to me that your pushback
has no real technical basis ...)
Out of around 300 platform drivers in the tree (and many more
not yet merged upstream), this makes it so that only *THREE* of
them can hotplug ... versus in the current tree, essentially
everything that's not a legacy driver is hotplugging just fine.
That's one heck of a regression. Just shy of 100% ...
Plus it treats rtc-ds1742 as if it's a platform_driver not
an i2c_driver.
- Dave
next prev parent reply other threads:[~2007-08-18 4:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 16:06 [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware Atsushi Nemoto
2007-08-17 10:59 ` Jan Engelhardt
2007-08-17 15:23 ` David Brownell
2007-08-17 15:37 ` Jan Engelhardt
2007-08-17 16:02 ` David Brownell
2007-08-17 16:15 ` Atsushi Nemoto
2007-08-17 16:26 ` David Brownell
2007-08-17 16:32 ` Kay Sievers
2007-08-17 16:55 ` David Brownell
2007-08-17 17:18 ` Kay Sievers
2007-08-17 19:50 ` David Brownell
2007-08-17 19:52 ` Jan Engelhardt
2007-08-17 20:20 ` David Brownell
2007-08-18 2:40 ` Kay Sievers
2007-08-18 4:06 ` David Brownell [this message]
2007-08-18 10:45 ` Kay Sievers
2007-08-20 1:44 ` legacy platform drivers and hotplugging David Brownell
2007-08-20 2:02 ` Atsushi Nemoto
2007-08-20 9:51 ` Kay Sievers
2007-08-19 12:57 ` [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware Atsushi Nemoto
2007-08-19 21:45 ` Kay Sievers
2007-08-20 1:48 ` David Brownell
2007-08-20 2:02 ` David Brownell
2007-08-20 2:16 ` Atsushi Nemoto
2007-08-17 16:04 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708172106.52940.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=a.zummo@towertech.it \
--cc=anemo@mba.ocn.ne.jp \
--cc=greg@kroah.com \
--cc=jengelh@computergmbh.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox