public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: linux-kernel@vger.kernel.org, Gerd Hoffmann <kraxel@redhat.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Bryan Wu <bryan.wu@analog.com>, Sonic Zhang <sonic.adi@gmail.com>,
	Mike Frysinger <vapier.adi@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [draft] Blackfin Early Printk implmentation
Date: Sat, 18 Aug 2007 08:23:33 +0200	[thread overview]
Message-ID: <20070818062333.GA26416@uranus.ravnborg.org> (raw)
In-Reply-To: <200708171607.32849.rgetz@blackfin.uclinux.org>

> > What was preventing you from just using the x86_64 code here?
> 
> Some was borrowed - but not much. since we don't support vga, or 16550 UARTs
> (Blackfin has it's own on-chip UART), I don't think this would work. 
> 
> Maybe I'm missing something - but I don't think so. Every one who implements
> implements direct IO to the hardware (except me, since I put it into the driver
> file, and force Sonic - the serial driver developer - to maintain it forever).
> 
> Most of the other early printks talks directly to the hardware.
I only looked at your version and it looked general thats why I brought
up the code sharing idea - which I agree is not possible.

> > Thinking that all should do the same so maybe alpha ought to change...
> 
> When I looked at all the printk implementations, I thought they were all
> kind of hokey, and not very common - but what do you want for a debug interface
> that lasts less than 5 seconds?
> 
> ./arch/x86_64/kernel/early_printk.c
> ./arch/blackfin/kernel/early_printk.c
> ./arch/sh64/kernel/early_printk.c
> ./arch/sh/kernel/early_printk.c
> ./arch/i386/kernel/early_printk.c
> ./arch/mips/kernel/early_printk.c
> 
> I didn't see an alpha implementation - where is it done?
Alpha uses the imlementation in lib/*print.c somehow.
And I think the right choice would be to implement
a private version of early_printk for alpha like the
other architectures do.

Thanks for the split-up. I could follow the changes now.

	Sam

  reply	other threads:[~2007-08-18  6:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-16  2:34 Early printk behaviour Robin Getz
2007-08-16  7:45 ` Gerd Hoffmann
2007-08-16 16:47   ` Mike Frysinger
2007-08-17  7:49     ` Gerd Hoffmann
2007-08-17 21:00       ` Robin Getz
2007-08-17 21:09         ` Mike Frysinger
2007-08-17 21:29           ` Robin Getz
2007-08-20  8:01         ` Gerd Hoffmann
2007-08-16 18:56   ` Robin Getz
2007-08-17 17:36   ` [draft] Blackfin Early Printk implmentation Robin Getz
2007-08-17 17:57     ` Mike Frysinger
2007-08-17 18:25       ` Robin Getz
2007-08-17 18:43         ` Mike Frysinger
2007-08-17 17:59     ` Sam Ravnborg
2007-08-17 20:07       ` Robin Getz
2007-08-18  6:23         ` Sam Ravnborg [this message]
2007-08-18 15:37           ` Robin Getz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070818062333.GA26416@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bryan.wu@analog.com \
    --cc=hpa@zytor.com \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgetz@blackfin.uclinux.org \
    --cc=sonic.adi@gmail.com \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox