From: Andi Kleen <ak@suse.de>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: discuss@x86-64.org, linux-kernel@vger.kernel.org, jh@suse.cz
Subject: Re: [PATCH] x86-64: memset optimization
Date: Sat, 18 Aug 2007 20:55:11 +0200 [thread overview]
Message-ID: <200708182055.11277.ak@suse.de> (raw)
In-Reply-To: <20070818075602.34350b25@freepuppy.rosehill.hemminger.net>
> The problem is that on x86-64 you are overriding memset()
I don't. You must be looking at old source
asm-x86_64/string.h 2.6.23rc3:
#define __HAVE_ARCH_MEMSET
void *memset(void *s, int c, size_t n);
I wanted to do the same on i386 too, but there were some minor obstacles.
The problem is that the out of line fallback i386 memset is currently
quite dumb and needs to be rewritten to expand the fill char on its
own like the x86-64 version. Probably best would be just to port
the x86-64 version. I just hadn't had time for that.
[Patches welcome, but if you do ask me for my old memset test harness]
-Andi
next prev parent reply other threads:[~2007-08-18 18:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 23:34 [PATCH] x86-64: memset optimization Stephen Hemminger
2007-08-18 7:17 ` Eric Dumazet
2007-08-18 9:46 ` Andi Kleen
2007-08-18 14:56 ` Stephen Hemminger
2007-08-18 18:55 ` Andi Kleen [this message]
2007-08-19 5:04 ` Stephen Hemminger
2007-08-19 18:24 ` [discuss] " Andi Kleen
2007-08-20 15:52 ` Stephen Hemminger
2007-08-20 15:51 ` Arjan van de Ven
2007-08-20 17:03 ` Roland Dreier
2007-08-20 18:16 ` Andi Kleen
2007-08-20 18:56 ` Jan Hubicka
2007-08-21 10:16 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708182055.11277.ak@suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=jh@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox