Re: [POWERPC] Fix for assembler -g

[Dave Jones <davej@redhat.com>]

On Mon, Aug 20, 2007 at 01:18:18PM -0700, Roland McGrath wrote:
 > > I'm still seeing failures with this.
 > > http://koji.fedoraproject.org/koji/getfile?taskID=110854&name=build.log
 > > shows..
 > > 
 > > lparmap.c: Assembler messages:
 > > lparmap.c:84: Error: file number 1 already allocated
 > > make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
 > > 
 > > Anything I can provide to help diagnose this?
 > 
 > Hmm.  Check the V=1 make output to see that the lparmap.c really got the -g0.
 > The log says it didn't.  Oops!  It looks like the patch that got committed is
 > the one that sets CFLAGS_lparmap.s, but really it needs to set
 > CFLAGS_lparmap.o instead (go kbuild).  Did I post the wrong one?  (It's only
 > one letter different.)  Sorry about that!  (I committed the right one to
 > Fedora, which you'd think would help Dave, but no.)
 
Ahh, my eyes missed that the one upstream was subtley different, so I
dropped the one you committed to Fedora without trying it.
In a way though, good thing, or mainline would have continued to be
broken :)

	Dave

-- 
http://www.codemonkey.org.uk