Re: [patch 09/14] Convert from class_device to device for SPI

David Brownell
2007-08-21T18:36:56Z

On Tuesday 21 August 2007, Tony Jones wrote:
> On Mon, Aug 20, 2007 at 03:48:15PM -0700, tonyj@suse.de wrote:
> >
> > Convert from class_device to device for drivers/spi. This is part of the work
> > to eliminate struct class_device.
>
> Signed-off-by: Tony Jones <tonyj@suse.de>

Yeah, "no signoff" was one of my first reactions to that. :)

Can you update the Documentation/spi/spi-summary text which is
invalidated by this change? That's part of why I rejected an
earlier version of this patch: since it broke the documentation,
it was incomplete.

The other reason was to explore removing the "struct class" too,
since it's not necessary. But it turns out to be simpler to
keep it in there to allocate the bus IDs. So I've changed my
mind, and will merge a patch like $SUBJECT if it's complete
(i.e. doesn't leave broken/invalid docs).

- Dave