Re: [patch 09/14] Convert from class_device to device for SPI

Kay Sievers
2007-08-23T22:08:50Z

On Thu, 2007-08-23 at 14:03 -0700, David Brownell wrote:
> On Tuesday 21 August 2007, Tony Jones wrote:
> > I believe this is the necessary documentation changes.
>
> Thanks. I have an update, plus updates for the mmc_spi
> driver (now in MM) which you didn't update.
>
> By the way, it's worth noting an incompatibility introduced
> through these conversions and CONFIG_SYSFS_DEPRECATED=n:
>
> - previously .../controller/spi_master:spi2 would be a
> symlink to /sys/class/spi_master/spi2

These "find the class device which has me as the parent"-symlinks are
removed with CONFIG_SYSFS_DEPRECATED=n, because these devices are direct
child directories now below the bus device and there is no need for such
links.

> - now, /sys/class/spi_master/spi2 is a symlink to
> .../controller/spi_master (with DEPRECATED=n).

Ugh! Are you sure, that is doesn't point to:
.../controller/spi_master/spi2/ ?

> The symlink direction is just noise ... the issue is that with
> this approach it's no longer possible to have one controller
> handle multiple SPI busses! A fix would involve maintaining
> the original "spi_master:spi2" name.

Sounds like a bug if that's what happened. Can you paste the output of
"tree" for the relevant parts here?

Thanks,
Kay