From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
hch@infradead.org, prasanna@in.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net
Subject: Re: [patch 04/11] Kprobes - declare kprobe_mutex static
Date: Tue, 21 Aug 2007 09:47:35 +0530 [thread overview]
Message-ID: <20070821041734.GC9226@in.ibm.com> (raw)
In-Reply-To: <20070820202146.263958314@polymtl.ca>
On Mon, Aug 20, 2007 at 04:19:06PM -0400, Mathieu Desnoyers wrote:
> Since it will not be used by other kernel objects, it makes sense to declare it
> static.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> CC: hch@infradead.org
> CC: prasanna@in.ibm.com
> CC: ananth@in.ibm.com
> CC: anil.s.keshavamurthy@intel.com
> CC: davem@davemloft.net
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-lttng/kernel/kprobes.c
> ===================================================================
> --- linux-2.6-lttng.orig/kernel/kprobes.c 2007-08-19 09:09:15.000000000 -0400
> +++ linux-2.6-lttng/kernel/kprobes.c 2007-08-19 17:18:07.000000000 -0400
> @@ -68,7 +68,7 @@ static struct hlist_head kretprobe_inst_
> /* NOTE: change this value only with kprobe_mutex held */
> static bool kprobe_enabled;
>
> -DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */
> +static DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */
> DEFINE_SPINLOCK(kretprobe_lock); /* Protects kretprobe_inst_table */
> static DEFINE_PER_CPU(struct kprobe *, kprobe_instance) = NULL;
>
>
> --
> Mathieu Desnoyers
> Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
> OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-08-21 4:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 20:19 [patch 00/11] Text Edit Lock / text poke Mathieu Desnoyers
2007-08-20 20:19 ` [patch 01/11] Fall back on interrupt disable in cmpxchg8b on 80386 and 80486 Mathieu Desnoyers
2007-08-20 20:38 ` Mathieu Desnoyers
2007-08-20 20:19 ` [patch 02/11] Kprobes - use a mutex to protect the instruction pages list Mathieu Desnoyers
2007-08-21 4:16 ` Ananth N Mavinakayanahalli
2007-08-20 20:19 ` [patch 03/11] Kprobes - do not use kprobes mutex in arch code Mathieu Desnoyers
2007-08-21 4:17 ` Ananth N Mavinakayanahalli
2007-08-20 20:19 ` [patch 04/11] Kprobes - declare kprobe_mutex static Mathieu Desnoyers
2007-08-21 4:17 ` Ananth N Mavinakayanahalli [this message]
2007-08-20 20:19 ` [patch 05/11] Text Edit Lock - Architecture Independent Code Mathieu Desnoyers
2007-08-20 20:19 ` [patch 06/11] Text Edit Lock - Alternative code for i386 and x86_64 Mathieu Desnoyers
2007-08-20 20:19 ` [patch 07/11] Text Edit Lock - kprobes architecture independent support Mathieu Desnoyers
2007-08-20 20:19 ` [patch 08/11] Text Edit Lock - kprobes i386 Mathieu Desnoyers
2007-08-20 20:19 ` [patch 09/11] Text Edit Lock - kprobes x86_64 Mathieu Desnoyers
2007-08-20 20:19 ` [patch 10/11] Text Edit Lock - i386 standardize debug rodata Mathieu Desnoyers
2007-08-20 20:19 ` [patch 11/11] Text Edit Lock - x86_64 " Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070821041734.GC9226@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox