public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: [patch 14/20] Hibernation: do not try to mark invalid PFNs as nosave
Date: Mon, 20 Aug 2007 23:55:37 -0700	[thread overview]
Message-ID: <20070821065537.GO5275@kroah.com> (raw)
In-Reply-To: <20070821065210.GA5275@kroah.com>

[-- Attachment #1: hibernation-do-not-try-to-mark-invalid-pfns-as-nosave.patch --]
[-- Type: text/plain, Size: 1094 bytes --]

-stable review patch.  If anyone has any objections, please let us know.

------------------
From: Rafael J. Wysocki <rjw@sisk.pl>

On some systems some PFNs reported by the early initialization code as 'nosave'
may be invalid. =A0If we try to set the corresponding bits in the hibernation
bitmap, BUG_ON() in memory_bm_find_bit() will be triggered and the system
won't be able to boot (cf. https://bugzilla.novell.com/show_bug.cgi?id=296242).

Prevent this from happening by verifying if the 'nosave' PFNs are valid in
mark_nosave_pages().

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 kernel/power/snapshot.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -709,7 +709,8 @@ static void mark_nosave_pages(struct mem
 				region->end_pfn << PAGE_SHIFT);
 
 		for (pfn = region->start_pfn; pfn < region->end_pfn; pfn++)
-			memory_bm_set_bit(bm, pfn);
+			if (pfn_valid(pfn))
+				memory_bm_set_bit(bm, pfn);
 	}
 }
 

-- 

  parent reply	other threads:[~2007-08-21  6:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070821064251.972690753@blue.kroah.org>
2007-08-21  6:52 ` [patch 00/20] 2.6.22-stable review Greg KH
2007-08-21  6:53   ` [patch 01/20] hwmon: fix w83781d temp sensor type setting Greg KH
2007-08-21  6:53   ` [patch 02/20] hwmon: (smsc47m1) restore missing name attribute Greg KH
2007-08-21  6:53   ` [patch 03/20] sky2: restore workarounds for lost interrupts Greg KH
2007-08-21  6:54   ` [patch 04/20] sky2: carrier management Greg KH
2007-08-21  6:54   ` [patch 05/20] sky2: check for more work before leaving NAPI Greg KH
2007-08-21  6:54   ` [patch 06/20] sky2: check drop truncated packets Greg KH
2007-08-21  6:54   ` [patch 07/20] revert "x86, serial: convert legacy COM ports to platform devices" Greg KH
2007-08-21  6:54   ` [patch 08/20] ACPICA: Fixed possible corruption of global GPE list Greg KH
2007-08-21  6:55   ` [patch 09/20] ACPICA: Clear reserved fields for incoming ACPI 1.0 FADTs Greg KH
2007-08-21  6:55   ` [patch 10/20] AVR32: Fix atomic_add_unless() and atomic_sub_unless() Greg KH
2007-08-21  6:55   ` [patch 11/20] r8169: avoid needless NAPI poll scheduling Greg KH
2007-08-21  6:55   ` [patch 12/20] forcedeth: fix random hang in forcedeth driver when using netconsole Greg KH
2007-08-21  6:55   ` [patch 13/20] libata: add ATI SB700 device IDs to AHCI driver Greg KH
2007-08-21  6:55   ` Greg KH [this message]
2007-08-21  6:55   ` [patch 15/20] i386: allow debuggers to access the vsyscall page with compat vDSO Greg KH
2007-08-21  6:55   ` [patch 16/20] x86_64: Check for .cfi_rel_offset in CFI probe Greg KH
2007-08-21  6:55   ` [patch 17/20] x86_64: Change PMDS invocation to single macro Greg KH
2007-08-21  6:56   ` [patch 18/20] i386: Handle P6s without performance counters in nmi watchdog Greg KH
2007-08-21  6:56   ` [patch 19/20] i386: Fix double fault handler Greg KH
2007-08-21  6:56   ` [patch 20/20] JFFS2 locking regression fix Greg KH
2007-08-21 15:33   ` [patch 00/20] 2.6.22-stable review Justin M. Forbes
2007-08-23  0:10     ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070821065537.GO5275@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=rjw@sisk.pl \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox