public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: sukadev@us.ibm.com
Cc: Daniel Pittman <daniel@rimspace.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Ingo Molnar <mingo@elte.hu>, Kirill Korotaev <dev@sw.ru>,
	Pavel Emelyanov <xemul@sw.ru>, Roland McGrath <roland@redhat.com>,
	"Serge E. Hallyn" <serue@us.ibm.com>,
	containers@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC,PATCH] fix /sbin/init signal handling
Date: Tue, 21 Aug 2007 14:30:02 +0400	[thread overview]
Message-ID: <20070821103002.GA164@tv-sign.ru> (raw)
In-Reply-To: <20070821071019.GA8641@us.ibm.com>

On 08/21, sukadev@us.ibm.com wrote:
> 
> I am still reviewing this patch and will try to plug in the multiple
> pid ns code and play with it some more in the next couple of days.

Thanks!

> But am curious why we need the in_interrupt() check and that too only
> for the container-init process.

For example, send_sigio(). We shouldn't send this signal to /sbin/init.
But what if the interrupted process is from the parent namespace?

> Also, maybe a dumb que, are the checks for SIG_IGN and SIG_DFL required
> both on sender side and the receiver side (get_signal_to_deliver())

get_signal_to_deliver() checks SIG_IGN/SIG_DFL, but I guess you meant
a special check for init.

Unless the patch is wrong, this is not needed. And, in fact we can't do
this anyway. Because get_signal_to_deliver() can't know if the signal
comes from parent namespace or not.

Oleg.


  reply	other threads:[~2007-08-21 10:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-19 15:08 [RFC,PATCH] fix /sbin/init signal handling Oleg Nesterov
2007-08-21  7:10 ` sukadev
2007-08-21 10:30   ` Oleg Nesterov [this message]
2007-08-21  9:31 ` Pavel Emelyanov
2007-08-21 10:40   ` Oleg Nesterov
2007-08-21 16:05 ` Serge E. Hallyn
2007-08-21 17:04   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070821103002.GA164@tv-sign.ru \
    --to=oleg@tv-sign.ru \
    --cc=containers@lists.osdl.org \
    --cc=daniel@rimspace.net \
    --cc=dev@sw.ru \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=roland@redhat.com \
    --cc=serue@us.ibm.com \
    --cc=sukadev@us.ibm.com \
    --cc=xemul@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox