From: David Brownell <david-b@pacbell.net>
To: Tony Jones <tonyj@suse.de>
Cc: linux-kernel@vger.kernel.org, kay.sievers@vrfy.org
Subject: Re: [patch 09/14] Convert from class_device to device for SPI
Date: Tue, 21 Aug 2007 11:28:28 -0700 [thread overview]
Message-ID: <200708211128.28552.david-b@pacbell.net> (raw)
In-Reply-To: <20070821150119.GH26519@suse.de>
On Tuesday 21 August 2007, Tony Jones wrote:
> On Mon, Aug 20, 2007 at 03:48:15PM -0700, tonyj@suse.de wrote:
> >
> > Convert from class_device to device for drivers/spi. This is part of the work
> > to eliminate struct class_device.
>
> Signed-off-by: Tony Jones <tonyj@suse.de>
Yeah, "no signoff" was one of my first reactions to that. :)
Can you update the Documentation/spi/spi-summary text which is
invalidated by this change? That's part of why I rejected an
earlier version of this patch: since it broke the documentation,
it was incomplete.
The other reason was to explore removing the "struct class" too,
since it's not necessary. But it turns out to be simpler to
keep it in there to allocate the bus IDs. So I've changed my
mind, and will merge a patch like $SUBJECT if it's complete
(i.e. doesn't leave broken/invalid docs).
- Dave
next prev parent reply other threads:[~2007-08-21 18:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 22:48 [patch 00/14] More patches to convert from struct class_device to struct device tonyj
2007-08-20 22:48 ` [patch 01/14] Convert from class_device to device for block/paride tonyj
2007-08-20 22:48 ` [patch 02/14] Convert from class_device to device for block/pktcdvd tonyj
2007-08-21 14:59 ` Tony Jones
2007-08-20 22:48 ` [patch 03/14] Convert from class_device to device for block/aoechr tonyj
2007-08-21 14:59 ` Tony Jones
2007-08-20 22:48 ` [patch 04/14] Convert from class_device to device for drivers/macintosh tonyj
2007-08-21 14:59 ` Tony Jones
2007-08-24 5:04 ` Benjamin Herrenschmidt
2007-08-20 22:48 ` [patch 05/14] Convert from class_device to device for cosa sync driver tonyj
2007-08-21 14:59 ` Tony Jones
2007-08-22 9:49 ` Jan Kasprzak
2007-08-20 22:48 ` [patch 06/14] Convert from class_device to device for MTD/mtdchar tonyj
2007-08-21 15:00 ` Tony Jones
2007-08-20 22:48 ` [patch 07/14] Convert from class_device to device for IDE/ide-tape tonyj
2007-08-21 15:00 ` Tony Jones
2007-08-20 22:48 ` [patch 08/14] Convert from class_device to device for DMA engine tonyj
2007-08-21 15:01 ` Tony Jones
2007-08-20 22:48 ` [patch 09/14] Convert from class_device to device for SPI tonyj
2007-08-21 15:01 ` Tony Jones
2007-08-21 18:28 ` David Brownell [this message]
2007-08-21 18:48 ` Tony Jones
2007-08-22 3:05 ` Tony Jones
2007-08-23 21:03 ` David Brownell
2007-08-23 22:12 ` Kay Sievers
2007-08-26 19:54 ` David Brownell
2007-08-26 20:20 ` Kay Sievers
2007-08-20 22:48 ` [patch 10/14] Convert from class_device to device for USB core tonyj
2007-08-21 15:01 ` Tony Jones
2007-08-20 22:48 ` [patch 11/14] Convert from class_device to device for USB host tonyj
2007-08-21 18:06 ` Tony Jones
2007-08-25 0:15 ` Greg KH
2007-08-20 22:48 ` [patch 12/14] Convert from class_device to device for TI flash media tonyj
2007-08-21 15:02 ` Tony Jones
2007-08-20 22:48 ` [patch 13/14] Convert from class_device to device for UCB1x00 tonyj
2007-08-21 15:02 ` Tony Jones
2007-08-20 22:48 ` [patch 14/14] Convert from class_device to device for ISDN capi tonyj
2007-08-21 9:14 ` Karsten Keil
2007-08-21 14:56 ` Tony Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708211128.28552.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tonyj@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox