public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ian Kent <raven@themaw.net>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	autofs mailing list <autofs@linux.kernel.org>
Subject: Re: [PATCH] autofs4: reinstate negatitive timeout of mount fails
Date: Tue, 21 Aug 2007 13:15:51 -0700	[thread overview]
Message-ID: <20070821131551.4026fb96.akpm@linux-foundation.org> (raw)
In-Reply-To: <1187688369.3318.12.camel@raven.themaw.net>

On Tue, 21 Aug 2007 17:26:09 +0800
Ian Kent <raven@themaw.net> wrote:

> Due to a change to fs/dcache.c:d_lookup() in the 2.6 kernel whereby only
> hashed dentrys are returned the negative caching of mount failures
> stopped working in the autofs4 module for nobrowse mount (ie. directory
> created at mount time and removed at umount or following a mount
> failure).
> 
> This patch keeps track of the dentrys from mount fails in order to be
> able check the timeout since the last fail and return the appropriate
> status. In addition the timeout value is settable at load time as a
> module option and via sysfs using the module
> parameter /sys/module/autofs4/parameters/negative_timeout.

Boy, that's a complex-looking patch.  I think I'll sit on this one
for 2.6.24 ;)

It seems to use a lot of list_for_each[_safe] which could
have been coded as list_for_each_entry[_safe], btw.


  parent reply	other threads:[~2007-08-21 20:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-21  9:26 [PATCH] autofs4: reinstate negatitive timeout of mount fails Ian Kent
2007-08-21 14:19 ` Peter Staubach
2007-08-22  2:49   ` Ian Kent
2007-08-22  9:55   ` Ian Kent
2007-08-22 11:05     ` [autofs] " Ian Kent
2007-08-21 20:15 ` Andrew Morton [this message]
2007-08-22  2:56   ` Ian Kent
2007-08-22  3:27     ` [autofs] " Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070821131551.4026fb96.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=autofs@linux.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raven@themaw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox