From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761945AbXHVI7y (ORCPT ); Wed, 22 Aug 2007 04:59:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757319AbXHVIxG (ORCPT ); Wed, 22 Aug 2007 04:53:06 -0400 Received: from 1wt.eu ([62.212.114.60]:1987 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbXHVIxE (ORCPT ); Wed, 22 Aug 2007 04:53:04 -0400 From: Willy Tarreau Message-Id: <20070822084009.%N@1wt.eu> References: <20070822083844.%N@1wt.eu> User-Agent: quilt/0.46-1 Date: Wed, 22 Aug 2007 11:39:08 +0200 To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Maik Hampel , NeilBrown , Andrew Morton , Greg Kroah-Hartman , Willy Tarreau Subject: [2.6.20.17 review 24/58] md: raid10: fix use-after-free of bio Content-Disposition: inline; filename=0024-md-raid10-fix-use-after-free-of-bio.patch Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org In case of read errors raid10d tries to print a nice error message, unfortunately using data from an already put bio. Signed-off-by: Maik Hampel Acked-By: NeilBrown Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman Signed-off-by: Willy Tarreau --- drivers/md/raid10.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index fb5d9c6..e0029ea 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1565,7 +1565,6 @@ static void raid10d(mddev_t *mddev) bio = r10_bio->devs[r10_bio->read_slot].bio; r10_bio->devs[r10_bio->read_slot].bio = mddev->ro ? IO_BLOCKED : NULL; - bio_put(bio); mirror = read_balance(conf, r10_bio); if (mirror == -1) { printk(KERN_ALERT "raid10: %s: unrecoverable I/O" @@ -1573,8 +1572,10 @@ static void raid10d(mddev_t *mddev) bdevname(bio->bi_bdev,b), (unsigned long long)r10_bio->sector); raid_end_bio_io(r10_bio); + bio_put(bio); } else { const int do_sync = bio_sync(r10_bio->master_bio); + bio_put(bio); rdev = conf->mirrors[mirror].rdev; if (printk_ratelimit()) printk(KERN_ERR "raid10: %s: redirecting sector %llu to" -- 1.5.2.5 --