From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762571AbXHVJDl (ORCPT ); Wed, 22 Aug 2007 05:03:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758725AbXHVIxf (ORCPT ); Wed, 22 Aug 2007 04:53:35 -0400 Received: from 1wt.eu ([62.212.114.60]:2099 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758651AbXHVIxc (ORCPT ); Wed, 22 Aug 2007 04:53:32 -0400 From: Willy Tarreau Message-Id: <20070822084036.%N@1wt.eu> References: <20070822083844.%N@1wt.eu> User-Agent: quilt/0.46-1 Date: Wed, 22 Aug 2007 11:39:31 +0200 To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: "David S. Miller" , Marcus Meissner , Greg Kroah-Hartman , Willy Tarreau Subject: [2.6.20.17 review 47/58] IPV6: /proc/net/anycast6 unbalanced inet6_dev refcnt Content-Disposition: inline; filename=0047-IPV6-proc-net-anycast6-unbalanced-inet6_dev-refcnt.patch Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Reading /proc/net/anycast6 when there is no anycast address on an interface results in an ever-increasing inet6_dev reference count, as well as a reference to the netdevice you can't get rid of. Signed-off-by: David S. Miller Cc: Marcus Meissner Signed-off-by: Greg Kroah-Hartman Signed-off-by: Willy Tarreau --- net/ipv6/anycast.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/ipv6/anycast.c b/net/ipv6/anycast.c index fe0c895..7cf5248 100644 --- a/net/ipv6/anycast.c +++ b/net/ipv6/anycast.c @@ -67,6 +67,7 @@ ip6_onlink(struct in6_addr *addr, struct net_device *dev) break; } read_unlock_bh(&idev->lock); + in6_dev_put(idev); } rcu_read_unlock(); return onlink; -- 1.5.2.5 --