public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 02/10] cio: change confusing message in cmf.
Date: Wed, 22 Aug 2007 14:36:05 +0200	[thread overview]
Message-ID: <20070822123642.278525659@de.ibm.com> (raw)
In-Reply-To: 20070822123603.501231302@de.ibm.com

[-- Attachment #1: 002-cio-cmf.diff --]
[-- Type: text/plain, Size: 1697 bytes --]

From: Cornelia Huck <cornelia.huck@de.ibm.com>

cmf currently prints a message that more than 4096 channels are not
allowed in basic mode - however, this can only be enforced if cmf was
a module (which is no longer possible). It makes much more sense to
not check the specified number of channels and just print a message if
the block for basic mode could not be allocated (which may happen for
any number of specified channels).

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

 drivers/s390/cio/cmf.c |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Index: quilt-2.6/drivers/s390/cio/cmf.c
===================================================================
--- quilt-2.6.orig/drivers/s390/cio/cmf.c
+++ quilt-2.6/drivers/s390/cio/cmf.c
@@ -594,6 +594,9 @@ alloc_cmb (struct ccw_device *cdev)
 			free_pages((unsigned long)mem, get_order(size));
 		} else if (!mem) {
 			/* no luck */
+			printk(KERN_WARNING "cio: failed to allocate area "
+			       "for measuring %d subchannels\n",
+			       cmb_area.num_channels);
 			ret = -ENOMEM;
 			goto out;
 		} else {
@@ -1279,13 +1282,6 @@ init_cmf(void)
 	case CMF_BASIC:
 		format_string = "basic";
 		cmbops = &cmbops_basic;
-		if (cmb_area.num_channels > 4096 || cmb_area.num_channels < 1) {
-			printk(KERN_ERR "cio: Basic channel measurement "
-			       "facility can only use 1 to 4096 devices\n"
-			       KERN_ERR "when the cmf driver is built"
-			       " as a loadable module\n");
-			return 1;
-		}
 		break;
 	case CMF_EXTENDED:
  		format_string = "extended";

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


  parent reply	other threads:[~2007-08-22 12:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-22 12:36 [patch 00/10] s390 patches for 2.6.23-rc3 Martin Schwidefsky
2007-08-22 12:36 ` [patch 01/10] cio: dont forget to set last slot to NULL in ccw_uevent() Martin Schwidefsky
2007-08-22 12:36 ` Martin Schwidefsky [this message]
2007-08-22 12:36 ` [patch 03/10] qdio: fix EQBS handling on CCQ96 Martin Schwidefsky
2007-08-22 12:36 ` [patch 04/10] qdio: Refresh buffer states for IQDIO Asynchronous output queue Martin Schwidefsky
2007-08-22 12:36 ` [patch 05/10] vmur: fix diag14 exceptions with addresses > 2GB Martin Schwidefsky
2007-08-22 12:36 ` [patch 06/10] vmur: fix reference counting for vmur device structure Martin Schwidefsky
2007-08-22 12:36 ` [patch 07/10] disassembler: fix b2 opcodes like srst, bsg, and others Martin Schwidefsky
2007-08-22 12:36 ` [patch 08/10] hypfs: inode corruption due to missing locking Martin Schwidefsky
2007-08-22 12:36 ` [patch 09/10] kprobes: fix instruction length calculation Martin Schwidefsky
2007-08-22 12:36 ` [patch 10/10] Change atomic_read/set to inline functions with barrier semantics Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070822123642.278525659@de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox